netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Fuzzey <mfuzzey@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, nico@cam.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] Ethtool style in kernel network driver configuration.
Date: Sat, 13 Jun 2009 09:00:10 +0200	[thread overview]
Message-ID: <4A334E7A.5020805@gmail.com> (raw)
In-Reply-To: <20090612.170128.213931980.davem@davemloft.net>

David Miller wrote:
> I don't expect anyone to be required to read a data-sheet just to
> prevent some link mode settings.
>
> If the driver isn't clean enough to make a change like that easy,
> that's a bug.
>
> This is just a scarecrow argument.
>   
Ok if you like.

But please reply to the rest of that message, in particular explain why,
having publicly stated you would accept an implementation of Nicolas'
idea, you are now back pedaling. I'm quite prepared to be told that the
code itself is not good enough yet (with indications of how to improve
it) but we're not even discussing the code.

The impression (and I sincerely hope I am wrong) this gives me is that
when you accepted the idea in principle you didn't think anyone would
actually step up and write the code [presumably because us embedded
people are too busy working on our quick hacks]. Well I did and now I'm
calling upon you to keep your word.

At the end of the day you are the networking maintainer and I'm a no
name so you can tell me to go jump in the lake. But think a little about
the message that would send first. To the best of my knowledge I
respected the linux development process by discussing first and
apparently reaching a consensus - it's not like I jumped in with a chunk
of code demanding it be merged. If I misunderstood the process please
tell me too.

Martin


  reply	other threads:[~2009-06-13  7:00 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 17:34 [RFC PATCH] Ethtool style in kernel network driver configuration Martin Fuzzey
2009-06-10 18:02 ` Joe Perches
2009-06-11  2:02 ` Ben Hutchings
2009-06-11  3:55   ` Nicolas Pitre
2009-06-11  6:47   ` Martin Fuzzey
2009-06-11 14:54     ` Ben Hutchings
2009-06-11 16:22       ` Nicolas Pitre
2009-06-11 16:52         ` Ben Hutchings
2009-06-11 17:44           ` Nicolas Pitre
2009-06-11 18:29             ` Ben Hutchings
2009-06-11 19:08               ` Nicolas Pitre
2009-06-11 19:31                 ` Ben Hutchings
2009-06-11 20:24                   ` Nicolas Pitre
2009-06-11 20:48                     ` Ben Hutchings
2009-06-11 21:39                       ` Martin Fuzzey
2009-06-12  0:15                     ` David Miller
2009-06-12  0:38                       ` Nicolas Pitre
2009-06-12  2:57                         ` David Miller
2009-06-11 17:45           ` Martin Fuzzey
2009-06-12  0:09             ` David Miller
2009-06-12 10:50               ` Mark Brown
2009-06-12 11:33                 ` David Miller
2009-06-12 12:24                   ` Mark Brown
2009-06-13  0:01                     ` David Miller
2009-06-13 17:10                       ` Mark Brown
2009-06-12 12:19               ` Martin Fuzzey
2009-06-13  0:01                 ` David Miller
2009-06-13  7:00                   ` Martin Fuzzey [this message]
2009-06-13  7:07                     ` David Miller
2009-06-13  7:51                       ` Martin Fuzzey
2009-06-13  8:07                         ` David Miller
2009-06-13  9:29                           ` Martin Fuzzey
2009-06-14 18:39                       ` Martin Fuzzey
2009-06-12  0:07           ` David Miller
2009-06-12  0:03         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A334E7A.5020805@gmail.com \
    --to=mfuzzey@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).