netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH v2] ftrace: change the export format of trace_kfree_skb()
Date: Fri, 19 Jun 2009 10:05:39 +0800	[thread overview]
Message-ID: <4A3AF273.6010502@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0906182033101.6890@gandalf.stny.rr.com>



Steven Rostedt wrote:

>> Changelog v1->v2:
>> Convert protocol from raw numeric to its name as Frederic's suggestion
>>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
>> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> 
> I get this:
> 
>   CC      net/core/net-traces.o
> In file included from include/trace/ftrace.h:262,
>                  from include/trace/define_trace.h:57,
>                  from include/trace/events/skb.h:107,
>                  from net/core/net-traces.c:28:
> include/trace/events/skb.h: In function 'ftrace_raw_output_kfree_skb':
> include/trace/events/skb.h:78: error: 'ETH_P_IEEE802154' undeclared (first 
> use in this function)
> include/trace/events/skb.h:78: error: (Each undeclared identifier is 
> reported only once
> include/trace/events/skb.h:78: error: for each function it appears in.)
> 

I use Ingo's tip tree and this build error not occur in my test, I also find
ETH_P_IEEE802154 is added by Sergey Lapin's patch, it's merged recently, can
be found here:
	http://marc.info/?l=git-commits-head&m=124515655608598&w=2

Could you check ETH_P_IEEE802154 is defined in include/linux/if_ether.h and
your code is the latest?

Thanks,
Xiao Guangrong

> -- Steve
> 
> 

  reply	other threads:[~2009-06-19  2:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09  5:54 [PATCH RESEND] ftrace: change the export format of trace_kfree_skb() Xiao Guangrong
2009-06-09 18:27 ` Frederic Weisbecker
2009-06-10  1:40   ` Xiao Guangrong
2009-06-10  1:56     ` Steven Rostedt
2009-06-10  7:26     ` Frederic Weisbecker
2009-06-18  3:26       ` [PATCH v2] " Xiao Guangrong
2009-06-18 10:35         ` Neil Horman
2009-06-18 12:51           ` Steven Rostedt
2009-06-18 14:08             ` Neil Horman
2009-06-24  6:58           ` David Miller
2009-06-26  1:24             ` Xiao Guangrong
2009-06-19  0:33         ` Steven Rostedt
2009-06-19  2:05           ` Xiao Guangrong [this message]
2009-06-19  2:11             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A3AF273.6010502@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).