From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC net 02/03]: allow to propagate errors through ->ndo_hard_start_xmit()
Date: Fri, 19 Jun 2009 14:23:25 +0200 [thread overview]
Message-ID: <4A3B833D.6040604@trash.net> (raw)
In-Reply-To: <20090616092531.GA6106@ff.dom.local>
Jarek Poplawski wrote:
> On 09-06-2009 18:17, Patrick McHardy wrote:
>> commit c2104095c3a1023b4f4809c90092145dff093c88
>> Author: Patrick McHardy <kaber@trash.net>
>> Date: Tue Jun 9 17:55:34 2009 +0200
>>
>> net: allow to propagate errors through ->ndo_hard_start_xmit()
>>
> ...
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index 11560e3..b2e9953 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -1731,6 +1731,8 @@ gso:
>> nskb->next = NULL;
>> rc = ops->ndo_start_xmit(nskb, dev);
>> if (unlikely(rc)) {
>> + if (rc & ~NETDEV_TX_MASK)
>> + return rc;
>
> This is probably not enough: what about the rest of the skb
> (qdisc_restart() would skip requeuing)?
Good point, I guess we should drop the remaining parts.
I'll fix that up, thanks.
next prev parent reply other threads:[~2009-06-19 12:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 16:16 [RFC net 00/03]: dev_queue_xmit error propagation Patrick McHardy
2009-06-09 16:17 ` [RFC net-sched 01/03]: use symbolic NET_XMIT constants in qdiscs Patrick McHardy
2009-06-09 16:17 ` [RFC net 02/03]: allow to propagate errors through ->ndo_hard_start_xmit() Patrick McHardy
2009-06-16 9:25 ` Jarek Poplawski
2009-06-19 12:23 ` Patrick McHardy [this message]
2009-06-09 16:17 ` [RFC vlan 03/03]: propagate transmission state Patrick McHardy
2009-06-09 16:34 ` Eric Dumazet
2009-06-09 16:37 ` Patrick McHardy
2009-06-11 10:18 ` [RFC net 00/03]: dev_queue_xmit error propagation David Miller
2009-06-11 16:33 ` Patrick McHardy
2009-06-12 0:05 ` David Miller
2009-06-12 0:10 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3B833D.6040604@trash.net \
--to=kaber@trash.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).