[PATCH] sh_eth: remove redundant test on unsigned

[PATCH] sh_eth: remove redundant test on unsigned

[Roel Kluin]

Unsigned boguscnt cannot be less than 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
or should I make boguscnt int?

diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index 341882f..a2d82dd 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -865,8 +865,7 @@ static irqreturn_t sh_eth_interrupt(int irq, void *netdev)
 	struct sh_eth_private *mdp = netdev_priv(ndev);
 	struct sh_eth_cpu_data *cd = mdp->cd;
 	irqreturn_t ret = IRQ_NONE;
-	u32 ioaddr, boguscnt = RX_RING_SIZE;
-	u32 intr_status = 0;
+	u32 ioaddr, intr_status = 0;
 
 	ioaddr = ndev->base_addr;
 	spin_lock(&mdp->lock);
@@ -901,12 +900,6 @@ static irqreturn_t sh_eth_interrupt(int irq, void *netdev)
 	if (intr_status & cd->eesr_err_check)
 		sh_eth_error(ndev, intr_status);
 
-	if (--boguscnt < 0) {
-		printk(KERN_WARNING
-		       "%s: Too much work at interrupt, status=0x%4.4x.\n",
-		       ndev->name, intr_status);
-	}
-
 other_irq:
 	spin_unlock(&mdp->lock);
 

Re: [PATCH] sh_eth: remove redundant test on unsigned

[David Miller]

From: Roel Kluin <roel.kluin@gmail.com>
Date: Mon, 22 Jun 2009 19:38:00 +0200

> Unsigned boguscnt cannot be less than 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

To be honest since this never possibly triggered, it never
provided any help diagnosing any problem, so removing the
test altogether is likely best.

I'll integrate this once -rc1 is out and it's OK for 2.6.32
bound stuff to start showing up in linux-next.

Thanks!