From: Joe Eykholt <jeykholt@cisco.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
Scott Feldman <scofeldm@cisco.com>,
Hannes Reinecke <hare@suse.de>,
James.Bottomley@HansenPartnership.com, davem@davemloft.net,
gospo@redhat.com, abjoglek@cisco.com, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Consolidate shared code between enic and fnic drivers.
Date: Tue, 23 Jun 2009 16:53:38 -0700 [thread overview]
Message-ID: <4A416B02.2040607@cisco.com> (raw)
In-Reply-To: <adazlbyoe7l.fsf@cisco.com>
Roland Dreier wrote:
> > For the includes then, do we put them in include/shared/cisco_vnic or
> > do we do that EXTRA_CFLAGS += -Idrivers/shared/cisco_vnic? In that
> > patch for fnic/vnic/enic I sent a while back I did the EXTRA_CFLAGS,
> > only because that is how cxgb3/iw_cxgb3 was doing it. I am not sure if
> > that is nice or not. It was on the TODO to check it out.
>
> For mlx4, I created include/linux/mlx4/.
>
> Maybe create include/shared and move to that?
Or how about include/drivers/mlx4 and similarly for cisco_vnic
(but we're leaning towards cvnic)?
include/drivers seems more like a generally useful subdirectory
with some meaning. include/shared leaves one guessing as to what
it might be.
Joe
next prev parent reply other threads:[~2009-06-23 23:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 5:05 [PATCH] Consolidate shared code between enic and fnic drivers Scott Feldman
2009-06-18 9:29 ` Hannes Reinecke
2009-06-18 17:03 ` Mike Christie
2009-06-18 17:19 ` Scott Feldman
2009-06-18 17:45 ` Mike Christie
2009-06-23 21:03 ` Roland Dreier
2009-06-23 23:53 ` Joe Eykholt [this message]
2009-06-25 16:38 ` Roland Dreier
2009-06-23 21:02 ` Roland Dreier
2009-06-18 14:03 ` Ben Hutchings
2009-06-23 20:58 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A416B02.2040607@cisco.com \
--to=jeykholt@cisco.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abjoglek@cisco.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).