From: Franco Fichtner <franco@marian.de>
To: Ron Mercer <ron.mercer@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [net-2.6 PATCH 1/2] qla3xxx: Give the PHY time to come out of reset.
Date: Wed, 24 Jun 2009 10:56:11 +0200 [thread overview]
Message-ID: <4A41EA2B.20306@marian.de> (raw)
In-Reply-To: <1245783602-6542-1-git-send-email-ron.mercer@qlogic.com>
Ron Mercer wrote:
> + /* Give the PHY time to come out of reset. */
> + mdelay(100);
>
Why *delay* for 100ms? This is something I pointed out quite a while ago
when
you first introduced your driver.
Looking at the other patch where you eventually replaced the delay with
a sleep
left the door wide open for a lock related issue. So I can see why the
delay works
"better" for you.
However, I also recall pointing out the locking in this driver needed
some work,
because there were spinlocks held over the duration of numerous function
calls.
It seemed like a mess, but nobody cared.
Franco
prev parent reply other threads:[~2009-06-24 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 19:00 [net-2.6 PATCH 1/2] qla3xxx: Give the PHY time to come out of reset Ron Mercer
2009-06-23 19:00 ` [net-2.6 PATCH 2/2] qla3xxx: Don't sleep while holding lock Ron Mercer
2009-06-23 23:36 ` David Miller
2009-06-23 23:36 ` [net-2.6 PATCH 1/2] qla3xxx: Give the PHY time to come out of reset David Miller
2009-06-24 8:56 ` Franco Fichtner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A41EA2B.20306@marian.de \
--to=franco@marian.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).