netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: nhorman@tuxdriver.com, mingo@elte.hu, fweisbec@gmail.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	rostedt@goodmis.org
Subject: Re: [PATCH v2] ftrace: change the export format of trace_kfree_skb()
Date: Fri, 26 Jun 2009 09:24:42 +0800	[thread overview]
Message-ID: <4A44235A.4090503@cn.fujitsu.com> (raw)
In-Reply-To: <20090623.235838.129947362.davem@davemloft.net>



David Miller wrote:
> FWIW there are parts I don't like about this change.
> 
> It's just the show_protocol_name() bit, it's designed to always be
> out of date.
> 
> Nobody is going to look at trace/events/skb.h when they add a new
> ETH_P_* value.
> 
> We could make some include/linux/eth_protos.def file, that has
> lines like:
> 
> ETHERNET_PROTOCOL(ETH_P_FOO, N)
> 
> then headers that want to instantiate something like the usual
> ETH_P_FOO defines or this symbolic printing table define
> "ETHERNET_PROTOCOL" to a suitable macro and then include
> linux/eth_protos.def to make the expansions.
> 

Thanks for your review and your nice solution.
I will fix it in next version. ;-)

Thanks,
Xiao

> 

  reply	other threads:[~2009-06-26  1:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09  5:54 [PATCH RESEND] ftrace: change the export format of trace_kfree_skb() Xiao Guangrong
2009-06-09 18:27 ` Frederic Weisbecker
2009-06-10  1:40   ` Xiao Guangrong
2009-06-10  1:56     ` Steven Rostedt
2009-06-10  7:26     ` Frederic Weisbecker
2009-06-18  3:26       ` [PATCH v2] " Xiao Guangrong
2009-06-18 10:35         ` Neil Horman
2009-06-18 12:51           ` Steven Rostedt
2009-06-18 14:08             ` Neil Horman
2009-06-24  6:58           ` David Miller
2009-06-26  1:24             ` Xiao Guangrong [this message]
2009-06-19  0:33         ` Steven Rostedt
2009-06-19  2:05           ` Xiao Guangrong
2009-06-19  2:11             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A44235A.4090503@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).