* [PATCH] sctp: xmit sctp packet always return no route error
@ 2009-06-29 8:49 Wei Yongjun
2009-06-29 11:14 ` Eric Dumazet
2009-06-29 13:12 ` Vlad Yasevich
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2009-06-29 8:49 UTC (permalink / raw)
To: David Miller, Vlad Yasevich, Eric Dumazet; +Cc: Netdev, linux-sctp
Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5)
broken the sctp protocol stack, the sctp packet can never be sent out after
Eric Dumazet's patch, which have typo in the sctp code.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/output.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/output.c b/net/sctp/output.c
index b764114..b94c211 100644
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
}
dst = dst_clone(tp->dst);
skb_dst_set(nskb, dst);
- if (dst)
+ if (!dst)
goto no_route;
/* Build the SCTP header. */
--
1.6.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sctp: xmit sctp packet always return no route error
2009-06-29 8:49 [PATCH] sctp: xmit sctp packet always return no route error Wei Yongjun
@ 2009-06-29 11:14 ` Eric Dumazet
2009-06-29 13:12 ` Vlad Yasevich
1 sibling, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2009-06-29 11:14 UTC (permalink / raw)
To: Wei Yongjun; +Cc: David Miller, Vlad Yasevich, Eric Dumazet, Netdev, linux-sctp
Wei Yongjun a écrit :
> Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5)
> broken the sctp protocol stack, the sctp packet can never be sent out after
> Eric Dumazet's patch, which have typo in the sctp code.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Oops, sorry !
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> net/sctp/output.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/output.c b/net/sctp/output.c
> index b764114..b94c211 100644
> --- a/net/sctp/output.c
> +++ b/net/sctp/output.c
> @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
> }
> dst = dst_clone(tp->dst);
> skb_dst_set(nskb, dst);
> - if (dst)
> + if (!dst)
> goto no_route;
>
> /* Build the SCTP header. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sctp: xmit sctp packet always return no route error
2009-06-29 8:49 [PATCH] sctp: xmit sctp packet always return no route error Wei Yongjun
2009-06-29 11:14 ` Eric Dumazet
@ 2009-06-29 13:12 ` Vlad Yasevich
2009-06-30 2:42 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Vlad Yasevich @ 2009-06-29 13:12 UTC (permalink / raw)
To: Wei Yongjun; +Cc: David Miller, Eric Dumazet, Netdev, linux-sctp
Wei Yongjun wrote:
> Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5)
> broken the sctp protocol stack, the sctp packet can never be sent out after
> Eric Dumazet's patch, which have typo in the sctp code.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Oh-oh!! Thanks for catching this.
Acked-by: Vlad Yasevich <vladisalv.yasevich@hp.com>
-vlad
> ---
> net/sctp/output.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/output.c b/net/sctp/output.c
> index b764114..b94c211 100644
> --- a/net/sctp/output.c
> +++ b/net/sctp/output.c
> @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
> }
> dst = dst_clone(tp->dst);
> skb_dst_set(nskb, dst);
> - if (dst)
> + if (!dst)
> goto no_route;
>
> /* Build the SCTP header. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sctp: xmit sctp packet always return no route error
2009-06-29 13:12 ` Vlad Yasevich
@ 2009-06-30 2:42 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-06-30 2:42 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: yjwei, eric.dumazet, netdev, linux-sctp
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Mon, 29 Jun 2009 09:12:54 -0400
> Wei Yongjun wrote:
>> Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5)
>> broken the sctp protocol stack, the sctp packet can never be sent out after
>> Eric Dumazet's patch, which have typo in the sctp code.
>>
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> Oh-oh!! Thanks for catching this.
>
> Acked-by: Vlad Yasevich <vladisalv.yasevich@hp.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-30 2:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-29 8:49 [PATCH] sctp: xmit sctp packet always return no route error Wei Yongjun
2009-06-29 11:14 ` Eric Dumazet
2009-06-29 13:12 ` Vlad Yasevich
2009-06-30 2:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).