From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
Netdev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: xmit sctp packet always return no route error
Date: Mon, 29 Jun 2009 09:12:54 -0400 [thread overview]
Message-ID: <4A48BDD6.1020001@hp.com> (raw)
In-Reply-To: <4A488021.50002@cn.fujitsu.com>
Wei Yongjun wrote:
> Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5)
> broken the sctp protocol stack, the sctp packet can never be sent out after
> Eric Dumazet's patch, which have typo in the sctp code.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Oh-oh!! Thanks for catching this.
Acked-by: Vlad Yasevich <vladisalv.yasevich@hp.com>
-vlad
> ---
> net/sctp/output.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sctp/output.c b/net/sctp/output.c
> index b764114..b94c211 100644
> --- a/net/sctp/output.c
> +++ b/net/sctp/output.c
> @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
> }
> dst = dst_clone(tp->dst);
> skb_dst_set(nskb, dst);
> - if (dst)
> + if (!dst)
> goto no_route;
>
> /* Build the SCTP header. */
next prev parent reply other threads:[~2009-06-29 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 8:49 [PATCH] sctp: xmit sctp packet always return no route error Wei Yongjun
2009-06-29 11:14 ` Eric Dumazet
2009-06-29 13:12 ` Vlad Yasevich [this message]
2009-06-30 2:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A48BDD6.1020001@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).