From: Zan Lynx <zlynx@acm.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
fbl@redhat.com, nhorman@redhat.com, davem@redhat.com,
oleg@redhat.com, eric.dumazet@gmail.com
Subject: Re: [PATCH] net: fix race in the receive/select
Date: Mon, 29 Jun 2009 10:59:57 -0600 [thread overview]
Message-ID: <4A48F30D.8000803@acm.org> (raw)
In-Reply-To: <87eit3l7y6.fsf@basil.nowhere.org>
Andi Kleen wrote:
> At least on x86 I can't see how it happens. mb() is only a compile
> time barrier and the compiler doesn't optimize over indirect callbacks
> like __pollwait() anyways.
Just a note about this. That used to be true, that GCC didn't optimize
indirect calls. However, see -findirect-inlining in GCC 4.4.
I am not saying that it applies here, but it is something to remember.
--
Zan Lynx
zlynx@acm.org
"Knowledge is Power. Power Corrupts. Study Hard. Be Evil."
next prev parent reply other threads:[~2009-06-29 17:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 12:25 [PATCH] net: fix race in the receive/select Jiri Olsa
2009-06-25 12:24 ` Oleg Nesterov
2009-06-26 1:31 ` Davide Libenzi
2009-06-26 1:59 ` Eric Dumazet
2009-06-26 2:04 ` Davide Libenzi
2009-06-26 2:11 ` David Miller
2009-06-26 2:19 ` Eric Dumazet
2009-06-26 3:14 ` Davide Libenzi
2009-06-26 5:42 ` Jarek Poplawski
2009-06-26 8:10 ` Jarek Poplawski
2009-06-26 13:57 ` Oleg Nesterov
2009-06-26 17:32 ` Davide Libenzi
2009-06-26 14:50 ` Oleg Nesterov
2009-06-26 18:12 ` Davide Libenzi
2009-06-26 18:17 ` David Miller
2009-06-26 19:35 ` Eric Dumazet
2009-06-29 9:34 ` Jiri Olsa
2009-06-28 11:10 ` Jarek Poplawski
2009-06-28 11:22 ` Jarek Poplawski
2009-06-28 18:04 ` Oleg Nesterov
2009-06-28 21:48 ` Jarek Poplawski
2009-06-29 9:27 ` Jiri Olsa
2009-06-26 13:46 ` Oleg Nesterov
2009-06-25 23:18 ` Eric Dumazet
2009-06-26 1:50 ` Tejun Heo
2009-06-29 9:12 ` Andi Kleen
2009-06-29 9:24 ` Jiri Olsa
2009-06-29 16:59 ` Zan Lynx [this message]
2009-06-29 17:29 ` Andi Kleen
2009-07-01 3:39 ` Herbert Xu
2009-07-01 6:27 ` Andi Kleen
2009-07-01 7:03 ` Herbert Xu
2009-07-01 7:22 ` Andi Kleen
2009-07-01 8:31 ` Herbert Xu
2009-07-01 8:44 ` Jiri Olsa
2009-07-01 10:58 ` Herbert Xu
2009-07-01 13:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A48F30D.8000803@acm.org \
--to=zlynx@acm.org \
--cc=andi@firstfloor.org \
--cc=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fbl@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).