From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-2?Q?Pawe=B3_Staszewski?= Subject: Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_root. Now=15 size=11 bits Date: Tue, 30 Jun 2009 22:16:57 +0200 Message-ID: <4A4A72B9.3030400@itcare.pl> References: <20090629083315.GA4712@ff.dom.local> <4A488EB8.4070602@itcare.pl> <20090629104703.GC4712@ff.dom.local> <20090630070929.GB5589@ff.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , Robert Olsson , Robert Olsson , "Jorge Boncompte [DTI2]" , Eric Dumazet , Robert Olsson , Linux Network Development list To: Jarek Poplawski Return-path: Received: from smtp.iq.pl ([86.111.241.19]:41998 "EHLO smtp.iq.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015AbZF3UQ5 (ORCPT ); Tue, 30 Jun 2009 16:16:57 -0400 In-Reply-To: <20090630070929.GB5589@ff.dom.local> Sender: netdev-owner@vger.kernel.org List-ID: Jarek Poplawski pisze: > On Mon, Jun 29, 2009 at 10:47:03AM +0000, Jarek Poplawski wrote: > =20 >> On Mon, Jun 29, 2009 at 11:51:52AM +0200, Pawe=B3 Staszewski wrote: >> =20 >>> I apply this patch >>> >>> fib_triestats in attached file :) >>> =20 >> Great! But it would be nice to check if this (accidentally ;-) might >> fix the previous problem, so I attach below the patch with "manual >> RCU", which btw. (or even more important) should verify RCU use here= =2E >> >> It should be applied on top of this last "Fix..., part3". And >> again: it's quite probable it can fail, so with caution, no hurry >> (it can wait for quiet time)... >> =20 > > Pawel, here is another try to check what's going on here, so just > like before, but this one on top of these 2 last working patches, > plus quite time... (Stats aren't necessary; if these are some doubts > let me know.) > > Thanks, > Jarek P. > --------------------> (synchronize_rcu take 5) > > diff -Nurp a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c > --- a/net/ipv4/fib_trie.c 2009-06-29 10:00:14.000000000 +0000 > +++ b/net/ipv4/fib_trie.c 2009-06-30 06:50:35.000000000 +0000 > @@ -1036,6 +1036,7 @@ static void trie_rebalance(struct trie * > =20 > rcu_assign_pointer(t->trie, (struct node *)tn); > tnode_free_flush(); > + synchronize_rcu(); > =20 > return; > } > =20 Apply and tested Traffic is not forwarded after apply this patch.:) > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > =20