From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Mark McLoughlin <markmc@redhat.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] bridge: make bridge-nf-call-*tables default configurable
Date: Wed, 01 Jul 2009 11:21:44 +0200 [thread overview]
Message-ID: <4A4B2AA8.3090406@trash.net> (raw)
In-Reply-To: <20090701090736.GA32306@gondor.apana.org.au>
Herbert Xu wrote:
> On Wed, Jul 01, 2009 at 10:57:02AM +0200, Patrick McHardy wrote:
>> People are apparently using this for stateful tracking and even
>> NAT on bridges, so I'm afraid we can't get rid of it completely.
>
> I think we should print out a nasty message warning the user
> if we detect that conntrack is used by bridge netfilter for the
> first time. If the user persists then at least they can't sue
> us for not warning them :)
Agreed, at least as long as this is still the default behaviour.
Mark, could you add this to your patch? br_nf_pre_routing_finish()
looks like a good place to print a warning when skb->nfct != NULL.
next prev parent reply other threads:[~2009-07-01 9:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1246379267.3749.42.camel@blaa>
2009-06-30 17:00 ` [PATCH] bridge: make bridge-nf-call-*tables default configurable Herbert Xu
2009-06-30 19:06 ` David Miller
2009-06-30 20:16 ` Jan Engelhardt
2009-06-30 20:57 ` Mark Smith
2009-06-30 21:30 ` Jan Engelhardt
2009-07-01 1:48 ` Herbert Xu
2009-07-01 1:15 ` Herbert Xu
2009-07-01 3:50 ` Jan Engelhardt
2009-07-01 4:10 ` Herbert Xu
2009-07-01 4:14 ` Ben Greear
2009-07-01 9:01 ` Patrick McHardy
2009-07-01 8:57 ` Patrick McHardy
2009-07-01 9:07 ` Herbert Xu
2009-07-01 9:21 ` Patrick McHardy [this message]
2009-07-01 16:33 ` Herbert Xu
2009-07-01 17:01 ` Patrick McHardy
2009-07-01 3:16 ` David Miller
2009-07-01 10:45 ` Mark McLoughlin
2009-07-01 10:51 ` Patrick McHardy
2009-07-01 16:02 ` David Miller
2009-07-01 16:05 ` Patrick McHardy
2009-07-01 16:08 ` David Miller
2009-07-01 21:18 ` Mark Smith
2009-07-01 16:02 ` David Miller
2009-07-01 16:26 ` Herbert Xu
2009-07-01 8:56 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4B2AA8.3090406@trash.net \
--to=kaber@trash.net \
--cc=herbert@gondor.apana.org.au \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).