From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sascha Hlusiak <contact@saschahlusiak.de>
Cc: netdev@vger.kernel.org, berni@birkenwald.de
Subject: Re: [PATCH] sit: fix regression: do not release skb->dst before xmit
Date: Sat, 11 Jul 2009 15:24:15 +0200 [thread overview]
Message-ID: <4A58927F.7040405@gmail.com> (raw)
In-Reply-To: <1247317289-27867-1-git-send-email-contact@saschahlusiak.de>
Sascha Hlusiak a écrit :
> The sit module makes use of skb->dst in it's xmit function,
> so since 93f154b594fe47 sit tunnels are broken, because the
> flag IFF_XMIT_DST_RELEASE is not unset.
>
> This patch unsets that flag for sit devices to fix this
> regression.
>
> Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> net/ipv6/sit.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index 68e5230..98b7327 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1018,6 +1018,7 @@ static void ipip6_tunnel_setup(struct net_device *dev)
> dev->hard_header_len = LL_MAX_HEADER + sizeof(struct iphdr);
> dev->mtu = ETH_DATA_LEN - sizeof(struct iphdr);
> dev->flags = IFF_NOARP;
> + dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
> dev->iflink = 0;
> dev->addr_len = 4;
> dev->features |= NETIF_F_NETNS_LOCAL;
next prev parent reply other threads:[~2009-07-11 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 13:01 [PATCH] sit: fix regression: do not release skb->dst before xmit Sascha Hlusiak
2009-07-11 13:24 ` Eric Dumazet [this message]
2009-07-12 3:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A58927F.7040405@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=berni@birkenwald.de \
--cc=contact@saschahlusiak.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).