* [PATCH] sit: fix regression: do not release skb->dst before xmit
@ 2009-07-11 13:01 Sascha Hlusiak
2009-07-11 13:24 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hlusiak @ 2009-07-11 13:01 UTC (permalink / raw)
To: netdev; +Cc: berni, Sascha Hlusiak
The sit module makes use of skb->dst in it's xmit function,
so since 93f154b594fe47 sit tunnels are broken, because the
flag IFF_XMIT_DST_RELEASE is not unset.
This patch unsets that flag for sit devices to fix this
regression.
Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
---
net/ipv6/sit.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 68e5230..98b7327 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -1018,6 +1018,7 @@ static void ipip6_tunnel_setup(struct net_device *dev)
dev->hard_header_len = LL_MAX_HEADER + sizeof(struct iphdr);
dev->mtu = ETH_DATA_LEN - sizeof(struct iphdr);
dev->flags = IFF_NOARP;
+ dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
dev->iflink = 0;
dev->addr_len = 4;
dev->features |= NETIF_F_NETNS_LOCAL;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sit: fix regression: do not release skb->dst before xmit
2009-07-11 13:01 [PATCH] sit: fix regression: do not release skb->dst before xmit Sascha Hlusiak
@ 2009-07-11 13:24 ` Eric Dumazet
2009-07-12 3:31 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2009-07-11 13:24 UTC (permalink / raw)
To: Sascha Hlusiak; +Cc: netdev, berni
Sascha Hlusiak a écrit :
> The sit module makes use of skb->dst in it's xmit function,
> so since 93f154b594fe47 sit tunnels are broken, because the
> flag IFF_XMIT_DST_RELEASE is not unset.
>
> This patch unsets that flag for sit devices to fix this
> regression.
>
> Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> net/ipv6/sit.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index 68e5230..98b7327 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1018,6 +1018,7 @@ static void ipip6_tunnel_setup(struct net_device *dev)
> dev->hard_header_len = LL_MAX_HEADER + sizeof(struct iphdr);
> dev->mtu = ETH_DATA_LEN - sizeof(struct iphdr);
> dev->flags = IFF_NOARP;
> + dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
> dev->iflink = 0;
> dev->addr_len = 4;
> dev->features |= NETIF_F_NETNS_LOCAL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sit: fix regression: do not release skb->dst before xmit
2009-07-11 13:24 ` Eric Dumazet
@ 2009-07-12 3:31 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-07-12 3:31 UTC (permalink / raw)
To: eric.dumazet; +Cc: contact, netdev, berni
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 11 Jul 2009 15:24:15 +0200
> Sascha Hlusiak a écrit :
>> The sit module makes use of skb->dst in it's xmit function,
>> so since 93f154b594fe47 sit tunnels are broken, because the
>> flag IFF_XMIT_DST_RELEASE is not unset.
>>
>> This patch unsets that flag for sit devices to fix this
>> regression.
>>
>> Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-12 3:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-11 13:01 [PATCH] sit: fix regression: do not release skb->dst before xmit Sascha Hlusiak
2009-07-11 13:24 ` Eric Dumazet
2009-07-12 3:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).