From: Eric Dumazet <eric.dumazet@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] Phonet: sockets list through proc_fs
Date: Mon, 20 Jul 2009 12:31:41 +0200 [thread overview]
Message-ID: <4A64478D.9030008@gmail.com> (raw)
In-Reply-To: <1248085261.4549.103.camel@violet>
Marcel Holtmann a écrit :
> Hi Remi,
>
>>>>>> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>>>>> isn't there are proper explaining commit message missing here?
>>>> AFAIK, a one-liners stick to the Subject line.
>>>>
>>>> (I use explicit From: due to my broken Microsoft-provided MTA).
>>> the From: is not the problem here. However it would be nice to have a
>>> description of the change. Especially details like this is for debugging
>>> or this is a public API or etc.
>> It's just like most network protocols exposing their sockets list in
>> /proc/net. Debugging/monitoring indeed.
>
> I think that for new protocols, we should not do this anymore and just
> use debugfs. Since that is exactly its job.
netstat uses /proc/net
iproute2 uses netlink
Now you suggest adding debugfs support ?
What a mess...
next prev parent reply other threads:[~2009-07-20 10:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 8:34 [PATCH] Phonet: sockets list through proc_fs Rémi Denis-Courmont
2009-07-20 8:36 ` Marcel Holtmann
2009-07-20 9:28 ` Rémi Denis-Courmont
2009-07-20 9:34 ` Marcel Holtmann
2009-07-20 9:47 ` Rémi Denis-Courmont
2009-07-20 10:21 ` Marcel Holtmann
2009-07-20 10:31 ` Eric Dumazet [this message]
2009-08-03 2:42 ` Arnaldo Carvalho de Melo
2009-07-20 10:32 ` Rémi Denis-Courmont
2009-07-20 10:43 ` David Miller
2009-07-20 12:07 ` Marcel Holtmann
2009-07-20 12:49 ` Rémi Denis-Courmont
2009-07-20 13:00 ` Marcel Holtmann
2009-07-20 14:09 ` David Miller
2009-07-20 14:25 ` Marcel Holtmann
2009-07-20 14:05 ` David Miller
2009-07-20 9:05 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2009-07-21 11:57 Rémi Denis-Courmont
2009-07-21 19:34 ` David Miller
2009-08-12 11:02 ` Rémi Denis-Courmont
2009-08-12 18:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A64478D.9030008@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).