From: Shan Wei <shanwei@cn.fujitsu.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
Netdev <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>
Subject: Re: [PATCH] TCP: Add comments to (near) all functions in tcp_output.c v2
Date: Mon, 20 Jul 2009 20:06:53 +0800 [thread overview]
Message-ID: <4A645DDD.8050402@cn.fujitsu.com> (raw)
In-Reply-To: <20090718103159.GB2682@basil.fritz.box>
Andi Kleen said:
>
> +/* Compute TCP options for ESTABLISHED sockets. This is not the
> + * final wire format yet.
> + */
typo, “network wire”?
> +/* Test if sending is allowed right now.
> + */
> int tcp_may_send_now(struct sock *sk)
Is it better to provide the condition be allowed?
+ /* Check the nagle, the congestion window and
+ * the send window, decide if sending is allowed right now.
+ */
next prev parent reply other threads:[~2009-07-20 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 20:40 [PATCH] TCP: Add comments to (near) all functions in tcp_output.c Andi Kleen
2009-07-18 6:38 ` Ilpo Järvinen
2009-07-18 10:31 ` [PATCH] TCP: Add comments to (near) all functions in tcp_output.c v2 Andi Kleen
2009-07-20 12:06 ` Shan Wei [this message]
2009-07-20 12:34 ` Andi Kleen
2009-07-20 12:46 ` Shan Wei
2009-07-20 14:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A645DDD.8050402@cn.fujitsu.com \
--to=shanwei@cn.fujitsu.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).