netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@Voltaire.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Jamie Lokier <jamie@shareable.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@web.de>,
	Mark McLoughlin <markmc@redhat.com>, Dor Laor <dlaor@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] net: add raw backend  - some performance measurements
Date: Tue, 21 Jul 2009 16:41:38 +0300	[thread overview]
Message-ID: <4A65C592.4060103@Voltaire.com> (raw)
In-Reply-To: <20090721121420.GA19236@gondor.apana.org.au>

Herbert Xu wrote:
> On Tue, Jul 21, 2009 at 03:01:42PM +0300, Michael S. Tsirkin wrote:

>> the thing to check then would be that some kind of misconfiguration
>> does not cause the bridge to flood your packets to multiple interfaces.

> Right, we should make sure that the interfaces are not in promiscous mode

Michael, Herbert, 

First, I don't see how flooding can happen in my setup, I have only two interfaces on 
the bridge (see below), a tap and a NIC (vlan) and the bridge will never attempt to forward
a packet through the port it was received. Second, the bridge always set all interfaces
attached to it to be in promiscous mode, see the call to dev_set_promiscuity() from br_add_if()
but this doesn't mean it applied flooding, it does mac learning...

Or.

# brctl show
bridge name     bridge id               STP enabled     interfaces
br0             8000.0030485f9977       no              eth1.4009
                                                        tap0

The VM mac is de:ab:be:01:01:09 and the remote node mac is 00:30:48:65:a6:2b, you 
can see that these two macs were learned by the bridge and hence no flooding is expected.

# brctl showmacs br0
port no mac addr                is local?       ageing timer
  1     00:30:48:5f:99:77       yes                0.00
  1     00:30:48:65:a6:2b       no                12.50
  2     06:f5:76:64:a0:d4       yes                0.00
  2     de:ab:be:01:01:09       no                 0.00

      reply	other threads:[~2009-07-21 13:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090701162115.GA4555@shareable.org>
     [not found] ` <4A4CA747.1050509@Voltaire.com>
     [not found]   ` <20090703023911.GD938@shareable.org>
     [not found]     ` <4A534EC4.5030209@voltaire.com>
     [not found]       ` <20090707145739.GB14392@shareable.org>
     [not found]         ` <4A54B0F1.3070201@voltaire.com>
     [not found]           ` <20090715203806.GF3056@shareable.org>
     [not found]             ` <4A647B72.5090404@Voltaire.com>
     [not found]               ` <20090720155308.GA9327@gondor.apana.org.au>
     [not found]                 ` <4A656824.7070100@Voltaire.com>
2009-07-21  7:25                   ` [Qemu-devel] [PATCH] net: add raw backend - some performance measurements Herbert Xu
2009-07-21 10:17                     ` Or Gerlitz
2009-07-21 10:27                     ` Michael S. Tsirkin
2009-07-21 11:05                       ` Or Gerlitz
2009-07-21 12:01                         ` Michael S. Tsirkin
2009-07-21 12:14                           ` Herbert Xu
2009-07-21 13:41                             ` Or Gerlitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A65C592.4060103@Voltaire.com \
    --to=ogerlitz@voltaire.com \
    --cc=anthony@codemonkey.ws \
    --cc=dlaor@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jamie@shareable.org \
    --cc=jan.kiszka@web.de \
    --cc=markmc@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).