From: Ben Dooks <ben@simtec.co.uk>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: KS8851 needs to depend on MII
Date: Wed, 22 Jul 2009 12:19:17 +0100 [thread overview]
Message-ID: <4A66F5B5.2050606@simtec.co.uk> (raw)
In-Reply-To: <1248261411-12533-1-git-send-email-a.beregalov@gmail.com>
Alexander Beregalov wrote:
> fix this build error when CONFIG_MII is not set
> drivers/net/ks8851.c:999: undefined reference to `generic_mii_ioctl'
> drivers/net/ks8851.c:1050: undefined reference to `mii_link_ok'
> drivers/net/ks8851.c:1056: undefined reference to `mii_nway_restart'
> drivers/net/ks8851.c:1044: undefined reference to `mii_ethtool_sset'
> drivers/net/ks8851.c:1038: undefined reference to `mii_ethtool_gset'
thanks, my test system has an DM9000 so that selected CONFIG_MII for me.
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: Ben Dooks <ben@simtec.co.uk>
> ---
> drivers/net/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 1dbaffd..3ed49f1 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1732,6 +1732,7 @@ config KS8842
> config KS8851
> tristate "Micrel KS8851 SPI"
> depends on SPI
> + select MII
> help
> SPI driver for Micrel KS8851 SPI attached network chip.
>
--
Ben Dooks, Software Engineer, Simtec Electronics
http://www.simtec.co.uk/
next prev parent reply other threads:[~2009-07-22 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 11:16 [PATCH] net: KS8851 needs to depend on MII Alexander Beregalov
2009-07-22 11:19 ` Ben Dooks [this message]
2009-07-22 16:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A66F5B5.2050606@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=a.beregalov@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).