* [PATCH] net: KS8851 needs to depend on MII
@ 2009-07-22 11:16 Alexander Beregalov
2009-07-22 11:19 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Beregalov @ 2009-07-22 11:16 UTC (permalink / raw)
To: linux-next, netdev, David Miller, ben; +Cc: Alexander Beregalov
fix this build error when CONFIG_MII is not set
drivers/net/ks8851.c:999: undefined reference to `generic_mii_ioctl'
drivers/net/ks8851.c:1050: undefined reference to `mii_link_ok'
drivers/net/ks8851.c:1056: undefined reference to `mii_nway_restart'
drivers/net/ks8851.c:1044: undefined reference to `mii_ethtool_sset'
drivers/net/ks8851.c:1038: undefined reference to `mii_ethtool_gset'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
drivers/net/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 1dbaffd..3ed49f1 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1732,6 +1732,7 @@ config KS8842
config KS8851
tristate "Micrel KS8851 SPI"
depends on SPI
+ select MII
help
SPI driver for Micrel KS8851 SPI attached network chip.
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: KS8851 needs to depend on MII
2009-07-22 11:16 [PATCH] net: KS8851 needs to depend on MII Alexander Beregalov
@ 2009-07-22 11:19 ` Ben Dooks
2009-07-22 16:33 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2009-07-22 11:19 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: netdev, David S. Miller
Alexander Beregalov wrote:
> fix this build error when CONFIG_MII is not set
> drivers/net/ks8851.c:999: undefined reference to `generic_mii_ioctl'
> drivers/net/ks8851.c:1050: undefined reference to `mii_link_ok'
> drivers/net/ks8851.c:1056: undefined reference to `mii_nway_restart'
> drivers/net/ks8851.c:1044: undefined reference to `mii_ethtool_sset'
> drivers/net/ks8851.c:1038: undefined reference to `mii_ethtool_gset'
thanks, my test system has an DM9000 so that selected CONFIG_MII for me.
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: Ben Dooks <ben@simtec.co.uk>
> ---
> drivers/net/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 1dbaffd..3ed49f1 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1732,6 +1732,7 @@ config KS8842
> config KS8851
> tristate "Micrel KS8851 SPI"
> depends on SPI
> + select MII
> help
> SPI driver for Micrel KS8851 SPI attached network chip.
>
--
Ben Dooks, Software Engineer, Simtec Electronics
http://www.simtec.co.uk/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: KS8851 needs to depend on MII
2009-07-22 11:19 ` Ben Dooks
@ 2009-07-22 16:33 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-07-22 16:33 UTC (permalink / raw)
To: ben; +Cc: a.beregalov, netdev
From: Ben Dooks <ben@simtec.co.uk>
Date: Wed, 22 Jul 2009 12:19:17 +0100
> Alexander Beregalov wrote:
>> fix this build error when CONFIG_MII is not set
>> drivers/net/ks8851.c:999: undefined reference to `generic_mii_ioctl'
>> drivers/net/ks8851.c:1050: undefined reference to `mii_link_ok'
>> drivers/net/ks8851.c:1056: undefined reference to `mii_nway_restart'
>> drivers/net/ks8851.c:1044: undefined reference to `mii_ethtool_sset'
>> drivers/net/ks8851.c:1038: undefined reference to `mii_ethtool_gset'
>
> thanks, my test system has an DM9000 so that selected CONFIG_MII for
> me.
>
>> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> Acked-by: Ben Dooks <ben@simtec.co.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-22 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-22 11:16 [PATCH] net: KS8851 needs to depend on MII Alexander Beregalov
2009-07-22 11:19 ` Ben Dooks
2009-07-22 16:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).