From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH V2 net-next-2.6] net: relax dst refcnt in input path
Date: Wed, 22 Jul 2009 14:40:06 +0200 [thread overview]
Message-ID: <4A6708A6.1090200@trash.net> (raw)
In-Reply-To: <4A670469.2050404@gmail.com>
Eric Dumazet wrote:
> diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
> index db46b4b..23e974b 100644
> --- a/net/ipv4/ip_input.c
> +++ b/net/ipv4/ip_input.c
> @@ -331,7 +331,7 @@ static int ip_rcv_finish(struct sk_buff *skb)
> */
> if (skb_dst(skb) == NULL) {
> int err = ip_route_input(skb, iph->daddr, iph->saddr, iph->tos,
> - skb->dev);
> + skb->dev, 1);
> if (unlikely(err)) {
> if (err == -EHOSTUNREACH)
> IP_INC_STATS_BH(dev_net(skb->dev),
The packet might get queued by netfilter after this. I think this needs
another skb_dst_force() in __nf_queue().
next prev parent reply other threads:[~2009-07-22 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 20:07 [PATCH net-next-2.6] net: relax dst refcnt in input path Eric Dumazet
2009-07-22 12:22 ` [PATCH V2 " Eric Dumazet
2009-07-22 12:40 ` Patrick McHardy [this message]
2009-07-22 15:40 ` Eric Dumazet
2009-08-06 20:35 ` David Miller
2009-08-07 5:05 ` Eric Dumazet
2009-08-07 5:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6708A6.1090200@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).