From: Patrick McHardy <kaber@trash.net>
To: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] be2net: Adding support for 802.1ad (q-in-q mode)
Date: Thu, 23 Jul 2009 12:12:56 +0200 [thread overview]
Message-ID: <4A6837A8.9040208@trash.net> (raw)
In-Reply-To: <20090723100533.GB3172@serverengines.com>
Sarveshwar Bandi wrote:
> On 23/07/09 11:48 +0200, Patrick McHardy wrote:
>> Sarveshwar Bandi wrote:
>>> On 23/07/09 11:25 +0200, Patrick McHardy wrote:
>>>> adapter->vlan_grp will always be the VLAN group associated directly with
>>>> the device, which is the group for the outer tag, not the inner one. So
>>>> this can't properly associate packets with the correct VLAN device.
>>>>
>>> In this case, vid is the inner vlan id in the packet. This is also the
>>> vlan id configured by vconfig.
>>
>> So where does the outer tag come from then? Please provide an example
>> how to configure this using Q-in-Q.
>>
> The outer vlan is totally transparent to the host. It is used by the NIC
> to demux packets across multiple pci network functions. Currently the
> outer vlan tags are configured on the NIC by OEM provided utilities.
I see. A proper changelog entry would have explained that and avoided
all this confusion. Not that I think using another tool for this is a
good solution, but no objections from a functional POV.
next prev parent reply other threads:[~2009-07-23 10:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 8:26 [PATCH] be2net: Adding support for 802.1ad (q-in-q mode) Sarveshwar Bandi
2009-07-23 8:47 ` Patrick McHardy
2009-07-23 9:02 ` Sarveshwar Bandi
2009-07-23 9:07 ` Patrick McHardy
2009-07-23 9:20 ` Sarveshwar Bandi
2009-07-23 9:25 ` Patrick McHardy
2009-07-23 9:45 ` Sarveshwar Bandi
2009-07-23 9:48 ` Patrick McHardy
2009-07-23 10:05 ` Sarveshwar Bandi
2009-07-23 10:12 ` Patrick McHardy [this message]
2009-07-23 16:23 ` David Miller
2009-07-23 16:33 ` Patrick McHardy
2009-07-23 17:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6837A8.9040208@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sarveshwarb@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).