From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] pppoe: fix race at init time Date: Wed, 29 Jul 2009 06:33:43 +0200 Message-ID: <4A6FD127.9080903@gmail.com> References: <43d009740907272340g7f98ed55lfff38bfedd867a99@mail.gmail.com> <4A6ECA3A.4050309@openvz.org> <4A6EEF69.1050001@cosmosbay.com> <4A6EF0BF.2050801@gmail.com> <4A6EF705.6070403@openvz.org> <4A6EFA35.3060309@gmail.com> <4A6EFB81.4090105@gmail.com> <4A6F017B.4060909@gmail.com> <4A6F397D.6010606@gmail.com> <20090728184834.GD4678@lenovo> <43d009740907282055t44bfa2e2md3afa514d4b2d7e6@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Cyrill Gorcunov , "David S. Miller" , Pavel Emelyanov , Andrew Morton , netdev@vger.kernel.org To: Igor M Podlesny Return-path: Received: from gw1.cosmosbay.com ([212.99.114.194]:50776 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbZG2Ed5 (ORCPT ); Wed, 29 Jul 2009 00:33:57 -0400 In-Reply-To: <43d009740907282055t44bfa2e2md3afa514d4b2d7e6@mail.gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Igor M Podlesny a =C3=A9crit : > 2009/7/29 Cyrill Gorcunov : >> [Eric Dumazet - Tue, Jul 28, 2009 at 07:46:37PM +0200] >> ... >> | So Igor still has a panic... lets try a third patch then :) > [...] >> Hmm. It seems the problem is not in pppoe_init_net since it's >> called *before* dev_add_pack via register_pernet_gen_device >> (which is protected by a global net mutex). Or I miss something? >> >> (sorry guys I have quite a limited internet connection this week) >=20 > At last the 3rd patch was also unable to fix the bug. >=20 Yes, Cyril is right, my patch was not necessary. Any chance you give us CR2 value of fault ? Do you still have a corruption by a 2 value somewhere ? (High 32 bits order in first jpeg you sent) 00000002.3dcc5244 instead of ffffXXXX.3dcc5244