netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Socketcan-core@lists.berlios.de,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH V3] CAN: Add Flexcan CAN controller driver
Date: Thu, 30 Jul 2009 22:22:11 +0200	[thread overview]
Message-ID: <4A7200F3.3010608@grandegger.com> (raw)
In-Reply-To: <4A719463.2060201@grandegger.com>

Wolfgang Grandegger wrote:
> Sascha Hauer wrote:
[...]
>> 	errcnt = readl(&regs->errcnt);
>> 	rxerr = (errcnt >> 8) & 0xff;
>> 	txerr = errcnt & 0xff;
>> 	if ((rxerr >= 96 || txerr >= 96) && state == CAN_STATE_ERROR_ACTIVE)
>> 		state = CAN_STATE_ERROR_WARNING;
> 
> Yes, or do not handle the state in the "case 0" above appropriately. The
> CAN spec only specifies the bus error states error active, error passive
> and bus off. The warning is somehow optional but available on most CAN
> controllers. Nevertheless, we should create a message if the ISR
> realizes a state changes.

FYI, I will be on holiday for the next 1.5 weeks.

Wolfgang.

  reply	other threads:[~2009-07-30 20:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29  8:20 [PATCH V3] CAN: Add Flexcan CAN controller driver Sascha Hauer
2009-07-29  8:45 ` Oliver Hartkopp
2009-07-29  9:09 ` Wolfgang Grandegger
2009-07-30  8:37   ` Sascha Hauer
2009-07-30  8:51     ` Wolfgang Grandegger
2009-07-30  9:27       ` Sascha Hauer
2009-07-30 12:38         ` Wolfgang Grandegger
2009-07-30 20:22           ` Wolfgang Grandegger [this message]
2009-07-31 11:20             ` Sascha Hauer
2009-08-02 19:22               ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7200F3.3010608@grandegger.com \
    --to=wg@grandegger.com \
    --cc=Socketcan-core@lists.berlios.de \
    --cc=netdev@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).