From: Nathan Williams <nathan@traverse.com.au>
To: Stoyan Gaydarov <sgayda2@uiuc.edu>
Cc: linux-kernel@vger.kernel.org, chas@cmf.nrl.navy.mil,
David.Woodhouse@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] [atm] fixed faulty check
Date: Fri, 31 Jul 2009 10:22:48 +1000 [thread overview]
Message-ID: <4A723958.3030807@traverse.com.au> (raw)
In-Reply-To: <1248949491-20796-1-git-send-email-sgayda2@uiuc.edu>
Stoyan Gaydarov wrote:
> This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
>
> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
> ---
> drivers/atm/solos-pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
> index 9359613..307321b 100644
> --- a/drivers/atm/solos-pci.c
> +++ b/drivers/atm/solos-pci.c
> @@ -372,7 +372,7 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
> }
>
> snr = next_string(skb);
> - if (!str)
> + if (!snr)
> return -EIO;
> attn = next_string(skb);
> if (!attn)
Thanks Stoyan. Julia Lawall found this error a few days ago, which has been applied to net-next-2.6.
prev parent reply other threads:[~2009-07-31 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 10:24 [PATCH 1/4] [atm] fixed faulty check Stoyan Gaydarov
2009-07-31 0:22 ` Nathan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A723958.3030807@traverse.com.au \
--to=nathan@traverse.com.au \
--cc=David.Woodhouse@intel.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgayda2@uiuc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).