* [PATCH 1/4] [atm] fixed faulty check
@ 2009-07-30 10:24 Stoyan Gaydarov
2009-07-31 0:22 ` Nathan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Stoyan Gaydarov @ 2009-07-30 10:24 UTC (permalink / raw)
To: linux-kernel; +Cc: Stoyan Gaydarov, chas, David.Woodhouse, nathan, netdev
This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
---
drivers/atm/solos-pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 9359613..307321b 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -372,7 +372,7 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
}
snr = next_string(skb);
- if (!str)
+ if (!snr)
return -EIO;
attn = next_string(skb);
if (!attn)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/4] [atm] fixed faulty check
2009-07-30 10:24 [PATCH 1/4] [atm] fixed faulty check Stoyan Gaydarov
@ 2009-07-31 0:22 ` Nathan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Williams @ 2009-07-31 0:22 UTC (permalink / raw)
To: Stoyan Gaydarov; +Cc: linux-kernel, chas, David.Woodhouse, netdev
Stoyan Gaydarov wrote:
> This patche fixes a spelling error that has resulted from copy and pasting. The location of the error was found using a semantic patch but the semantic patch was not trying to find these errors. After looking things over it seemed logical that this change was needed. Please review it and then include the patch if it is in fact the correct change.
>
> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
> ---
> drivers/atm/solos-pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
> index 9359613..307321b 100644
> --- a/drivers/atm/solos-pci.c
> +++ b/drivers/atm/solos-pci.c
> @@ -372,7 +372,7 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
> }
>
> snr = next_string(skb);
> - if (!str)
> + if (!snr)
> return -EIO;
> attn = next_string(skb);
> if (!attn)
Thanks Stoyan. Julia Lawall found this error a few days ago, which has been applied to net-next-2.6.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-31 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-30 10:24 [PATCH 1/4] [atm] fixed faulty check Stoyan Gaydarov
2009-07-31 0:22 ` Nathan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).