* [PATCH] s6gmac: Read buffer overflow
@ 2009-08-02 6:20 Roel Kluin
2009-08-02 19:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-02 6:20 UTC (permalink / raw)
To: davem, netdev, Andrew Morton
Check whether index is within bounds before testing the element.
In the last iteration i is PHY_MAX_ADDR. the condition
`!(p = pd->mii.bus->phy_map[PHY_MAX_ADDR])' is undefined and may
evaluate to false, which leads to a dereference of this invalid
phy_map in the phy_connect() below.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/s6gmac.c b/drivers/net/s6gmac.c
index 5345e47..4525cbe 100644
--- a/drivers/net/s6gmac.c
+++ b/drivers/net/s6gmac.c
@@ -793,7 +793,7 @@ static inline int s6gmac_phy_start(struct net_device *dev)
struct s6gmac *pd = netdev_priv(dev);
int i = 0;
struct phy_device *p = NULL;
- while ((!(p = pd->mii.bus->phy_map[i])) && (i < PHY_MAX_ADDR))
+ while ((i < PHY_MAX_ADDR) && (!(p = pd->mii.bus->phy_map[i])))
i++;
p = phy_connect(dev, dev_name(&p->dev), &s6gmac_adjust_link, 0,
PHY_INTERFACE_MODE_RGMII);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s6gmac: Read buffer overflow
2009-08-02 6:20 [PATCH] s6gmac: Read buffer overflow Roel Kluin
@ 2009-08-02 19:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-08-02 19:31 UTC (permalink / raw)
To: roel.kluin; +Cc: netdev, akpm
From: Roel Kluin <roel.kluin@gmail.com>
Date: Sun, 02 Aug 2009 08:20:13 +0200
> Check whether index is within bounds before testing the element.
> In the last iteration i is PHY_MAX_ADDR. the condition
> `!(p = pd->mii.bus->phy_map[PHY_MAX_ADDR])' is undefined and may
> evaluate to false, which leads to a dereference of this invalid
> phy_map in the phy_connect() below.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-02 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-02 6:20 [PATCH] s6gmac: Read buffer overflow Roel Kluin
2009-08-02 19:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).