From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory Haskins Subject: Re: [PATCH 6/7] net: Add vbus_enet driver Date: Mon, 03 Aug 2009 16:24:10 -0400 Message-ID: <4A77476A.1030001@gmail.com> References: <20090803171030.17268.26962.stgit@dev.haskins.net> <20090803171801.17268.93846.stgit@dev.haskins.net> <20090803113030.3092d5b0@nehalam> <4A77443D.9020105@novell.com> <20090803131927.6f653556@nehalam> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0B70D64D9F73FB923974D8FD" Cc: Gregory Haskins , linux-kernel@vger.kernel.org, alacrityvm-devel@lists.sourceforge.net, netdev@vger.kernel.org To: Stephen Hemminger Return-path: In-Reply-To: <20090803131927.6f653556@nehalam> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0B70D64D9F73FB923974D8FD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Stephen Hemminger wrote: > On Mon, 03 Aug 2009 16:10:37 -0400 > Gregory Haskins wrote: >=20 >> Stephen Hemminger wrote: >>> On Mon, 03 Aug 2009 13:18:02 -0400 >>> Gregory Haskins wrote: >>> >>>> + >>>> +static const struct net_device_ops vbus_enet_netdev_ops =3D { >>>> + .ndo_open =3D vbus_enet_open, >>>> + .ndo_stop =3D vbus_enet_stop, >>>> + .ndo_set_config =3D vbus_enet_config, >>>> + .ndo_start_xmit =3D vbus_enet_tx_start, >>>> + .ndo_change_mtu =3D vbus_enet_change_mtu, >>>> + .ndo_tx_timeout =3D vbus_enet_timeout, >>>> +}; >>> >>> Missing=20 >>> .ndo_set_mac_address =3D eth_mac_addr, >>> .ndo_validate_addr =3D eth_validate_addr, >>> >> Ack. >> >>> Also, should have change_mtu. >> note that I do have .ndo_change_mtu. I assume this is what you are >> referring to and just missed it. If there is something else I need >> there, let me know. >=20 > If you don't have a change_mtu, then MTU is unlimited. Is "change_mtu" different from .ndo_change_mtu" on the ndo struct? That's whats confusing me, as I have the .ndo one already. Is there something else I need in addition, or should I be ok as is? > Can the device handle 64K or larger transfers? Well, its been tested with 64K GSO packets at least. I think it could handle arbitrarily large packets as long as they are paged, but I have never tried this beyond 64k due to the simple L4 limitations of 64k. Thanks Stephen, -Greg --------------enig0B70D64D9F73FB923974D8FD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkp3R2oACgkQP5K2CMvXmqHn1ACgjI5YhuvED29ZpAcviHHIiwo6 mg8An38icNKfF9CELsCqPy4DLYEzGEgh =3ROs -----END PGP SIGNATURE----- --------------enig0B70D64D9F73FB923974D8FD--