From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: john.dykstra1@gmail.com, mangoo@wpkg.org, netdev@vger.kernel.org
Subject: Re: WARNING: at net/ipv4/af_inet.c:155 inet_sock_destruct+0x122/0x13a()
Date: Tue, 04 Aug 2009 08:18:34 +0200 [thread overview]
Message-ID: <4A77D2BA.3040304@gmail.com> (raw)
In-Reply-To: <20090803.212007.253928711.davem@davemloft.net>
David Miller a écrit :
> From: John Dykstra <john.dykstra1@gmail.com>
> Date: Mon, 03 Aug 2009 19:38:01 -0500
>
>> There's a good chance e51a67a9c8a2ea5c563f8c2ba6613fe2100ffe67 from the
>> current mainline will fix this problem.
>>
>> Dave, Eric's fix might be a candidate for -stable. The symptom is
>> usually a WARN, but the impact is significant.
>
> Hmmm, I'll double-check. I thought I had submitted this one.
>
> Thanks for the heads up.
Hmm, I dont see how this patch could solve Tomasz case...
Since commit 2b85a34e911bf483c27cfdd124aeb1605145dc80
(net: No more expensive sock_hold()/sock_put() on each tx)
was not part of 2.6.30.4 AFAIK
This is the WARN_ON(sk->sk_forward_alloc) that triggers...
Sounds like a truesize mismatch rather than a sk_refcount one ?
next prev parent reply other threads:[~2009-08-04 6:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 8:30 WARNING: at net/ipv4/af_inet.c:155 inet_sock_destruct+0x122/0x13a() Tomasz Chmielewski
2009-08-04 0:38 ` John Dykstra
2009-08-04 4:20 ` David Miller
2009-08-04 6:18 ` Eric Dumazet [this message]
2009-08-12 20:00 ` Vlad Yasevich
2009-08-13 15:21 ` John Dykstra
2009-08-13 17:04 ` Vlad Yasevich
2009-08-13 18:16 ` Tomasz Chmielewski
2009-08-04 20:04 ` John Dykstra
2009-08-04 20:35 ` Tomasz Chmielewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A77D2BA.3040304@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=john.dykstra1@gmail.com \
--cc=mangoo@wpkg.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).