* [PATCH 2/2] sky2: Reset tx train after interrupts disabled
@ 2009-08-04 9:26 Mike McCormack
0 siblings, 0 replies; only message in thread
From: Mike McCormack @ 2009-08-04 9:26 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Reseting the tx chain too soon results in invalid tx queue positions
being delivered in the status queue. This also makes sure there's no
overlap between the cleanup done by sky2_tx_clean() and sky2_tx_done().
Signed-off-by: Mike McCormack <mikem@ring3k.org>
---
drivers/net/sky2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index cb3412a..e9cb1e7 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -1875,8 +1875,6 @@ static int sky2_down(struct net_device *dev)
&& port == 0 && hw->dev[1] && netif_running(hw->dev[1])))
sky2_write8(hw, SK_REG(port, GMAC_CTRL), GMC_RST_SET);
- sky2_tx_reset(sky2);
-
sky2_write8(hw, SK_REG(port, RX_GMF_CTRL_T), GMF_RST_SET);
/* Force any delayed status interrrupt and NAPI */
@@ -1901,6 +1899,8 @@ static int sky2_down(struct net_device *dev)
/* turn off LED's */
sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
+ sky2_tx_reset(sky2);
+
sky2_tx_clean(dev);
sky2_rx_clean(sky2);
--
1.5.6.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-08-04 9:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-04 9:26 [PATCH 2/2] sky2: Reset tx train after interrupts disabled Mike McCormack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).