From: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wolfgang Grandegger <wg@grandegger.com>,
dbaryshkov@gmail.com, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org, "Thuermann, Urs,
Dr. (K-EFFI/I)" <urs.thuermann@volkswagen.de>,
Lothar Wassmann <LW@KARO-electronics.de>,
netdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating can device
Date: Tue, 11 Aug 2009 11:36:52 +0200 [thread overview]
Message-ID: <4A813BB4.6070109@volkswagen.de> (raw)
In-Reply-To: <4A813AEF.7000002@trash.net>
Patrick McHardy wrote:
>
>>> You could add a ->newlink() function that unconditionally returns
>>> an error.
>>>
>>>
>>>
>> Yes, that fixed it.
>>
>> I created a can_newlink() function just returning -EINVAL ...
>>
>> I'll cook a patch and send it on netdev (when it gets online again).
>>
>
> I'd suggest to use EOPNOTSUPP for consistency.
>
>
Ok. Will do so.
Thanks!
Oliver
next prev parent reply other threads:[~2009-08-11 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-13954-10286@http.bugzilla.kernel.org/>
2009-08-11 4:54 ` [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating can device Andrew Morton
2009-08-11 7:52 ` Oliver Hartkopp
2009-08-11 8:22 ` Patrick McHardy
2009-08-11 9:26 ` Oliver Hartkopp
2009-08-11 9:33 ` Patrick McHardy
2009-08-11 9:36 ` Oliver Hartkopp [this message]
2009-08-14 6:23 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A813BB4.6070109@volkswagen.de \
--to=oliver.hartkopp@volkswagen.de \
--cc=LW@KARO-electronics.de \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=urs.thuermann@volkswagen.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).