From: Avi Kivity <avi@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, "Ira W. Snyder" <iws@ovro.caltech.edu>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] vhost_net: a kernel-level virtio server
Date: Thu, 13 Aug 2009 18:37:21 +0300 [thread overview]
Message-ID: <4A843331.1020402@redhat.com> (raw)
In-Reply-To: <200908131653.47029.arnd@arndb.de>
On 08/13/2009 05:53 PM, Arnd Bergmann wrote:
> On Thursday 13 August 2009, Michael S. Tsirkin wrote:
>
>> The best way to do this IMO would be to add zero copy support to raw
>> sockets, vhost will then get it basically for free.
>>
>
> Yes, that would be nice. I wonder if that could lead to security
> problems on TX though. I guess It will only bring significant performance
> improvements if we leave the data writable in the user space or guest
> during the operation. If the user finds the right timing, it could
> modify the frame headers after they have been checked using netfilter,
> or while the frames are being consumed in the kernel (e.g. an NFS
> server running in a guest).
>
IIRC when the kernel consumes data it linearizes the skb. We just need
to make sure all the zerocopy data is in the nonlinear part, and the
kernel will copy if/when it needs to access packet data.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-08-13 15:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1249930169.git.mst@redhat.com>
2009-08-10 18:53 ` [PATCH 1/2] export cpu_tlbstate to modules Michael S. Tsirkin
2009-08-10 21:56 ` H. Peter Anvin
2009-08-10 22:06 ` Michael S. Tsirkin
2009-08-10 22:24 ` H. Peter Anvin
2009-08-11 11:19 ` Michael S. Tsirkin
2009-08-10 18:53 ` [PATCH 2/2] vhost_net: a kernel-level virtio server Michael S. Tsirkin
2009-08-10 19:51 ` Arnd Bergmann
2009-08-10 20:10 ` Michael S. Tsirkin
2009-08-10 22:16 ` Arnd Bergmann
2009-08-12 17:03 ` Arnd Bergmann
2009-08-12 17:19 ` Ira W. Snyder
2009-08-12 17:31 ` Michael S. Tsirkin
2009-08-12 17:48 ` Ira W. Snyder
2009-08-13 5:55 ` Michael S. Tsirkin
2009-08-12 17:21 ` Michael S. Tsirkin
2009-08-12 17:59 ` Arnd Bergmann
2009-08-12 19:27 ` Anthony Liguori
2009-08-13 6:31 ` Michael S. Tsirkin
2009-08-13 6:06 ` Michael S. Tsirkin
2009-08-13 13:38 ` Arnd Bergmann
2009-08-13 13:48 ` Arnd Bergmann
2009-08-13 14:41 ` Michael S. Tsirkin
2009-08-13 14:53 ` Arnd Bergmann
2009-08-13 15:37 ` Avi Kivity [this message]
2009-08-20 7:25 ` Rusty Russell
2009-08-13 14:39 ` Michael S. Tsirkin
2009-08-13 14:58 ` Arnd Bergmann
2009-08-13 15:03 ` Michael S. Tsirkin
2009-08-12 19:22 ` Anthony Liguori
2009-08-13 8:45 ` Michael S. Tsirkin
2009-08-13 13:45 ` Arnd Bergmann
2009-08-12 19:58 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A843331.1020402@redhat.com \
--to=avi@redhat.com \
--cc=arnd@arndb.de \
--cc=iws@ovro.caltech.edu \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).