netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] via-velocity: Fix test of mii_status bit VELOCITY_DUPLEX_FULL
@ 2009-08-14 12:09 Roel Kluin
  2009-08-14 23:31 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-14 12:09 UTC (permalink / raw)
  To: netdev, Andrew Morton, Francois Romieu, David S. Miller

Test whether VELOCITY_DUPLEX_FULL bit is set in mii_status.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
// vi drivers/net/via-velocity.h +1448
#define     VELOCITY_DUPLEX_FULL           0x00000010UL

diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 3ba3595..cee08a1 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -1778,7 +1778,7 @@ static void velocity_error(struct velocity_info *vptr, int status)
 			 *	 mode
 			 */
 			if (vptr->rev_id < REV_ID_VT3216_A0) {
-				if (vptr->mii_status | VELOCITY_DUPLEX_FULL)
+				if (vptr->mii_status & VELOCITY_DUPLEX_FULL)
 					BYTE_REG_BITS_ON(TCR_TB2BDIS, &regs->TCR);
 				else
 					BYTE_REG_BITS_OFF(TCR_TB2BDIS, &regs->TCR);

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-14 23:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-14 12:09 [PATCH] via-velocity: Fix test of mii_status bit VELOCITY_DUPLEX_FULL Roel Kluin
2009-08-14 23:31 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).