From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [PATCH 2.6.30-rc4] r8169: avoid losing MSI interrupts Date: Sun, 23 Aug 2009 19:17:17 +0200 Message-ID: <4A91799D.7090802@gmail.com> References: <200903041828.49972.m.bueker@berlin.de> <1242001754.4093.12.camel@obelisk.thedillows.org> <200905112248.44868.mb@bu3sch.de> <200905112310.08534.mb@bu3sch.de> <1242077392.3716.15.camel@lap75545.ornl.gov> <4A09DC3E.2080807@googlemail.com> <1242268709.4979.7.camel@obelisk.thedillows.org> <4A0C6504.8000704@googlemail.com> <1242328457.32579.12.camel@lap75545.ornl.gov> <4A0C7443.1010000@googlemail.com> <1243042174.3580.23.camel@obelisk.thedillows.org> <1250895567.23419.1.camel@obelisk.thedillows.org> <1250897657.23419.5.camel@obelisk.thedillows.org> <1250973787.3582.14.camel@obelisk.thedillows.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: "Eric W. Biederman" , Michael Riepe , Michael Buesch , Francois Romieu , Rui Santos , =?ISO-8859-15?Q?Michael_B=FCker?= , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Michal Soltys To: David Dillow Return-path: In-Reply-To: <1250973787.3582.14.camel@obelisk.thedillows.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Dillow wrote, On 08/22/2009 10:43 PM: > On Sat, 2009-08-22 at 05:07 -0700, Eric W. Biederman wrote: >> ebiederm@xmission.com (Eric W. Biederman) writes: >> >>> David Dillow writes: >>> >>>> Re-looking at the code, I'd guess that some IRQ status line is getting >>>> stuck high, but I don't see why -- we should acknowledge all outstanding >>>> interrupts each time through the loop, whether we care about them or >>>> not. >>>> >>>> Could reproduce a problem with the following patch applied, and send the >>>> full dmesg, please? >>> Here is what I get. >>> >>> r8169 screaming irq status 00000085 mask 0000ffff event 0000803f napi 0000001d >> And now that the machine has come out of it, that was followed by: >> Looks like the soft lockup did not manage to trigger in this case. > > I need some more context, please. What is the network load through this > NIC when you have the issues? Light, heavy? Can you give me more details > about the machine? A full dmesg from boot until this happens would help > quite a bit. At a minimum it would help answer which version of the chip > we're dealing with and what the machine it is in looks like. > > Can you reproduce this with pci=nomsi? I'm assuming it the chip running > in MSI mode. > > Also, can you reproduce it when booting UP (or maxcpus=1)? I'm thinking > about a race between rtl8169_interrupt() and rtl8169_poll(), but it > isn't jumping out at me. > > Also, I'm having connectivity troubles this weekend, so my response may > be spotty. :( > BTW, FYI, it seems Michal stopped tracking this problem, but he found this commit problematic as well. From: Michal Soltys Subject: Re: r8169 (+others ?) and note_interrupt performance hit on 2.6.30.x Date: Wed, 05 Aug 2009 20:54:47 +0200 http://marc.info/?l=linux-netdev&m=124949848110710&w=2 Jarek P.