From: Patrick McHardy <kaber@trash.net>
To: Maximilian Engelhardt <maxi@daemonizer.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: Logic for SNAT persistent handling introduced in 2.6.30 is inverted
Date: Mon, 24 Aug 2009 19:28:37 +0200 [thread overview]
Message-ID: <4A92CDC5.2060707@trash.net> (raw)
In-Reply-To: <200908241516.16544.maxi@daemonizer.de>
Maximilian Engelhardt wrote:
> Kernel 2.6.30 introduced a patch [1] for the persistent option in the
> netfilter SNAT target. This is exactly what we need here so I had a quick look
> at the code and noticed that the patch is wrong. The logic is simply inverted.
> The patch below fixes this.
Good catch, applied. I'm wondering what the people who requested and
tested this change did actually test :)
> Also note that because of this the default behavior of the SNAT target has
> changed since kernel 2.6.30 as it now ignores the destination IP in choosing
> the source IP for nating (which should only be the case if the persistent
> option is set).
It fortunately only affects NAT to a range of IPs, which isn't
used that much.
prev parent reply other threads:[~2009-08-24 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 13:16 Logic for SNAT persistent handling introduced in 2.6.30 is inverted Maximilian Engelhardt
2009-08-24 17:28 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A92CDC5.2060707@trash.net \
--to=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maxi@daemonizer.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).