From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Wei Yongjun <yjwei@cn.fujitsu.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] trace_events: fix napi's tracepoint
Date: Wed, 26 Aug 2009 13:20:18 +0800 [thread overview]
Message-ID: <4A94C612.60200@cn.fujitsu.com> (raw)
In-Reply-To: <4A93895F.4010708@cn.fujitsu.com>
Xiao Guangrong wrote:
> Currently, the napi's tracepoint works will is depend on
> "DECLARE_TRACE" definiens in include/trace/define_trace.h,
> like below:
>
> #include <trace/events/skb.h> // include define_trace.h
> #include <trace/events/napi.h>
>
> there have error, if we remove "#include <trace/events/skb.h>"
> or include napi.h in the front of include skb.h, It should
> depend on the definiens in include/linux/tracepoint.h and we
> can remove the "DECLARE_TRACE" definiens in
> include/trace/define_trace.h, because "TRACE_EVENT" not use it
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Hi Steven,
I'm sorry, please pull this patch too, because
"[PATCH 7/8] tracing/events: fix the include file dependencies"
is based on this patch, else will occur building error.
Thanks,
Xiao
next prev parent reply other threads:[~2009-08-26 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A937EF5.4040505@cn.fujitsu.com>
2009-08-25 6:49 ` [PATCH 1/2] trace_events: fix napi's tracepoint Xiao Guangrong
2009-08-25 7:58 ` Ingo Molnar
2009-08-25 10:57 ` Neil Horman
2009-08-26 0:49 ` Xiao Guangrong
2009-08-26 5:20 ` Xiao Guangrong [this message]
2009-08-26 5:40 ` Xiao Guangrong
2009-08-26 14:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A94C612.60200@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rostedt@goodmis.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).