From: Or Gerlitz <ogerlitz@voltaire.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Patrick McHardy <kaber@trash.net>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [net-next 6/10] bnx2x: Update vlan_features
Date: Wed, 26 Aug 2009 17:18:09 +0300 [thread overview]
Message-ID: <4A954421.2010808@voltaire.com> (raw)
In-Reply-To: <3426.1248464836@death.nxdomain.ibm.com>
Jay Vosburgh wrote:
> Patrick, can you clarify one bit about your above statment? You
> say the bonding features should be an "intersection"; is that a strict
> intersection (i.e., slave1->vlan_features | slave2->vlan_features), or
> does the NETIF_F_ONE_FOR_ALL logic apply for vlan_features as it does
> for regular dev->features (using netdev_incrmenet_features() to combine
> the feature sets)?
>
> In other words, if a bond has two slaves, one with, e.g.,
> NETIF_F_SG in its vlan_features, and the other slave has 0 in
> vlan_features, should the bond's vlan_features be NETIF_F_SG, or 0?
>
Hi Jay,
So we're @ rc7 again and the "bonding: propogate vlan_features to
bonding master" patch isn't queued yet... can you look into that so we
have this for 2.6.32?
thanks,
Or.
prev parent reply other threads:[~2009-08-26 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 15:47 [net-next 6/10] bnx2x: Update vlan_features Eilon Greenstein
2009-07-23 10:46 ` Patrick McHardy
2009-07-23 11:14 ` Or Gerlitz
2009-07-23 11:21 ` Patrick McHardy
2009-07-23 11:30 ` Or Gerlitz
2009-07-23 18:47 ` Jay Vosburgh
2009-07-24 19:47 ` Jay Vosburgh
2009-08-26 14:18 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A954421.2010808@voltaire.com \
--to=ogerlitz@voltaire.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).