* [PATCH] tipc: fix test of bearer_priority range in tipc_register_media()
@ 2009-08-27 12:03 Roel Kluin
2009-08-29 7:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-27 12:03 UTC (permalink / raw)
To: Per Liden, tipc-discussion, Andrew Morton, David S. Miller,
netdev
For the bearer_priority to be less than TIPC_MIN_LINK_PRI and greater than
TIPC_MAX_LINK_PRI is logically impossible.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index a7a3677..327011f 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -119,7 +119,7 @@ int tipc_register_media(u32 media_type,
warn("Media <%s> rejected, no broadcast address\n", name);
goto exit;
}
- if ((bearer_priority < TIPC_MIN_LINK_PRI) &&
+ if ((bearer_priority < TIPC_MIN_LINK_PRI) ||
(bearer_priority > TIPC_MAX_LINK_PRI)) {
warn("Media <%s> rejected, illegal priority (%u)\n", name,
bearer_priority);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tipc: fix test of bearer_priority range in tipc_register_media()
2009-08-27 12:03 [PATCH] tipc: fix test of bearer_priority range in tipc_register_media() Roel Kluin
@ 2009-08-29 7:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-08-29 7:21 UTC (permalink / raw)
To: roel.kluin; +Cc: per.liden, tipc-discussion, akpm, netdev
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 27 Aug 2009 14:03:15 +0200
> For the bearer_priority to be less than TIPC_MIN_LINK_PRI and greater than
> TIPC_MAX_LINK_PRI is logically impossible.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied to net-next-2.6, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-29 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-27 12:03 [PATCH] tipc: fix test of bearer_priority range in tipc_register_media() Roel Kluin
2009-08-29 7:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).