public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "van der Linden, Frank" <fllinden@amazon.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection
Date: Mon, 11 Jun 2018 23:43:51 +0000	[thread overview]
Message-ID: <4A996A47-0BA5-4880-BDAD-05037407F1B9@amazon.com> (raw)
In-Reply-To: <20599722-9a2f-38c8-e4b8-d2eaf40197ab@gmail.com>

Yeah, true, it's missing INERRS in this case. I'll fix it up a bit.

Frank

On 6/11/18, 4:38 PM, "Eric Dumazet" <eric.dumazet@gmail.com> wrote:

    
    
    On 06/11/2018 04:25 PM, van der Linden, Frank wrote:
    > A few comments on this one:
    > 
    > - obviously this is fairly serious, as it can let corrupted data all the way up to the application
    
    Sure, although anyone relying on CRC checksum for ensuring TCP data integrity
    has big troubles ;)
    
    I would rather have a refined version of this patch doing a "goto csum_error" 
    so that we properly increment TCP_MIB_CSUMERRORS and TCP_MIB_INERRS 
    
    Thanks !
    
    


  reply	other threads:[~2018-06-11 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 23:15 [PATCH] tcp: verify the checksum of the first data segment in a new connection Frank van der Linden
2018-06-11 23:25 ` van der Linden, Frank
2018-06-11 23:37   ` Eric Dumazet
2018-06-11 23:43     ` van der Linden, Frank [this message]
2018-06-12 21:44       ` van der Linden, Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A996A47-0BA5-4880-BDAD-05037407F1B9@amazon.com \
    --to=fllinden@amazon.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox