From: Mike McCormack <mikem@ring3k.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org,
Rene Mayrhofer <rene.mayrhofer@gibraltar.at>,
Richard Leitner <leitner@esys.at>
Subject: Re: [PATCH] sky2: Don't try to turn led off in sky2_down()
Date: Sun, 30 Aug 2009 09:37:54 +0900 [thread overview]
Message-ID: <4A99C9E2.30001@ring3k.org> (raw)
In-Reply-To: <20090829105727.6281202e@s6510>
Stephen Hemminger wrote:
> On Sat, 29 Aug 2009 22:10:33 +0900
> Mike McCormack <mikem@ring3k.org> wrote:
>
>> There are a few problems with the following line of code in sky2_down()
>>
>> sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
>>
>> * It doesn't specify which port's LED to turn off.
>> * We don't turn send LED_STAT_ON on in sky2_up()
>> * B0_LED is 0x0006 in the vendor driver, but 0x0005 in sky2.
>> B0_LED is right next to B0_POWER_CTRL, so this is possibly
>> accounts for the device being accidently powered down as
>> reported by Rene Mayrhofer.
>
> I would rather just change the definition of B0_LED to the correct value.
How does that address the first problem? If there are two ports, which port's LED are we turning off?
thanks,
Mike
next prev parent reply other threads:[~2009-08-30 0:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 13:10 [PATCH] sky2: Don't try to turn led off in sky2_down() Mike McCormack
2009-08-29 13:17 ` Mike McCormack
2009-08-29 17:57 ` Stephen Hemminger
2009-08-30 0:37 ` Mike McCormack [this message]
2009-08-31 9:48 ` Rene Mayrhofer
2009-08-31 9:58 ` Rene Mayrhofer
2009-09-03 16:16 ` [PATCH] sky2: only enable Vaux if capable of wakeup Stephen Hemminger
2009-09-04 3:10 ` David Miller
2009-09-04 11:55 ` Rene Mayrhofer
2009-08-31 17:31 ` [PATCH] sky2: fix management of driver LED Stephen Hemminger
2009-09-02 0:44 ` David Miller
2009-09-02 4:33 ` Stephen Hemminger
2009-09-02 7:28 ` Rene Mayrhofer
2009-09-02 7:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A99C9E2.30001@ring3k.org \
--to=mikem@ring3k.org \
--cc=leitner@esys.at \
--cc=netdev@vger.kernel.org \
--cc=rene.mayrhofer@gibraltar.at \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).