From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
David Miller <davem@davemloft.net>,
Wei Yongjun <yjwei@cn.fujitsu.com>,
Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH resend] drop_monitor: fix trace_napi_poll_hit()
Date: Mon, 31 Aug 2009 15:33:50 +0200 [thread overview]
Message-ID: <4A9BD13E.4040501@gmail.com> (raw)
In-Reply-To: <20090831111245.GA2105@hmsreliant.think-freely.org>
Neil Horman a écrit :
> I still see a large number of drivers that update dev->last_rx, although its
> not all as I look through the list, so something definately seems amiss.
Some drivers still update dev->last_rx for their own needs, not a core
network concern.
But a cleanup is certainly possible on few other drivers, about a dozen
if I count correctly.
>
> If its not going to be consistently updated, why are still carrying that field
> in dev? Are we just waiting on someone to do the janitorial work to remove it?
> If so, I can, and I'll fix up the drop monitor in the process, to use a private
> timestamp.
We have to keep dev->last_rx for bonding use, so please use a private
timestamp for drop monitor.
Thanks
next prev parent reply other threads:[~2009-08-31 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 6:10 [PATCH resend] drop_monitor: fix trace_napi_poll_hit() Xiao Guangrong
2009-08-31 6:31 ` Eric Dumazet
2009-08-31 11:12 ` Neil Horman
2009-08-31 11:47 ` David Miller
2009-08-31 13:33 ` Eric Dumazet [this message]
2009-08-31 15:42 ` Neil Horman
2009-08-31 16:34 ` [PATCH net-next-2.6] drivers: Kill now superfluous ->last_rx stores Eric Dumazet
2009-08-31 17:37 ` Neil Horman
2009-09-03 6:09 ` David Miller
2009-09-02 1:20 ` [PATCH resend] drop_monitor: fix trace_napi_poll_hit() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9BD13E.4040501@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).