netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sachin Sant <sachinp@in.ibm.com>
To: netdev <netdev@vger.kernel.org>
Cc: linux-next@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: [Patch -next] Fix net/3c503.c build break
Date: Fri, 04 Sep 2009 16:06:02 +0530	[thread overview]
Message-ID: <4AA0ED92.6070306@in.ibm.com> (raw)
In-Reply-To: <20090904182309.dbb05c96.sfr@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Today's Next failed to build on a x86 box with following error.

drivers/net/3c503.c: In function 'el2_open':
drivers/net/3c503.c:406: error: 'reval' undeclared (first use in this function)
drivers/net/3c503.c:406: error: (Each undeclared identifier is reported only once
drivers/net/3c503.c:406: error: for each function it appears in.)

Most probably because of commit ab08999d6029bb2c79c16be5405d63d2bedbdfea
The patch had a typo in it. Below patch fixes the issue for me.

Thanks
-Sachin



[-- Attachment #2: net-3c503-typo-fix.patch --]
[-- Type: text/x-patch, Size: 497 bytes --]

Fix a build break because of a typo in drivers/net/3c503.c

Signed-off-by: Sachin Sant <sachinp@in.ibm.com>
---
diff -Naurp a/drivers/net/3c503.c b/drivers/net/3c503.c
--- a/drivers/net/3c503.c	2009-09-04 15:50:06.000000000 +0530
+++ b/drivers/net/3c503.c	2009-09-04 15:50:41.000000000 +0530
@@ -403,7 +403,7 @@ el2_open(struct net_device *dev)
 		    break;
 	    } else {
 		    if (retval != -EBUSY)
-			    return reval;
+			    return retval;
 	    }
 	} while (*++irqp);
 	if (*irqp == 0) {

       reply	other threads:[~2009-09-04 10:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090904182309.dbb05c96.sfr@canb.auug.org.au>
2009-09-04 10:36 ` Sachin Sant [this message]
2009-09-04 10:41   ` [Patch -next] Fix net/3c503.c build break David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA0ED92.6070306@in.ibm.com \
    --to=sachinp@in.ibm.com \
    --cc=davem@davemloft.net \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).