From: Brian Haley <brian.haley@hp.com>
To: Jens Rosenboom <jens@mcbone.net>
Cc: david Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag
Date: Tue, 08 Sep 2009 11:18:44 -0400 [thread overview]
Message-ID: <4AA675D4.8030406@hp.com> (raw)
In-Reply-To: <1252418247.5827.8.camel@fnki-nb00130>
Jens Rosenboom wrote:
>> --- a/net/ipv6/addrconf.c
>> +++ b/net/ipv6/addrconf.c
>> @@ -1376,7 +1376,7 @@ static void addrconf_dad_stop(struct inet6_ifaddr *ifp)
>> if (ifp->flags&IFA_F_PERMANENT) {
>> spin_lock_bh(&ifp->lock);
>> addrconf_del_timer(ifp);
>> - ifp->flags |= IFA_F_TENTATIVE;
>> + ifp->flags |= IFA_F_DADFAILED;
>
> I think you still have to set IFA_F_TENTATIVE here, too, otherwise
> ipv6_dev_get_saddr() will use this address.
The tentative bit is still set from when this address was added back
in ipv6_add_addr() from what I can tell, re-setting it here is actually
unnecessary. At least /sbin/ip was still showing it set during my
testing.
-Brian
next prev parent reply other threads:[~2009-09-08 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 1:38 [PATCH] ipv6: Add IFA_F_DADFAILED flag Brian Haley
2009-09-08 13:57 ` Jens Rosenboom
2009-09-08 15:18 ` Brian Haley [this message]
2009-09-08 15:43 ` Jens Rosenboom
2009-09-10 0:41 ` Brian Haley
2009-09-10 16:11 ` Jens Rosenboom
2009-09-10 19:14 ` Brian Haley
2009-12-02 0:01 ` Stephen Hemminger
2009-09-11 19:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA675D4.8030406@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=jens@mcbone.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).