From: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: netdev <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH -next] netxen: build fix for INET=n
Date: Fri, 11 Sep 2009 15:46:29 -0700 [thread overview]
Message-ID: <4AAAD345.4090902@qlogic.com> (raw)
In-Reply-To: <20090911154104.1804a82f.randy.dunlap@oracle.com>
grr .. I broke it again!
Thanks Randy for fixing.
Acked-by: Dhananjay Phadke <dhananjay@netxen.com>
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When CONFIG_INET is disabled, netxen has a build failure:
>
> netxen_nic_main.c:(.text+0x118fd1): undefined reference to `netxen_config_indev_addr'
>
> so make that function just an empty stub when CONFIG_INET=n.
> (not "inline" since that conflicts with other declarations of it)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/net/netxen/netxen_nic_main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- linux-next-20090911.orig/drivers/net/netxen/netxen_nic_main.c
> +++ linux-next-20090911/drivers/net/netxen/netxen_nic_main.c
> @@ -2450,6 +2450,10 @@ static struct notifier_block netxen_netd
> static struct notifier_block netxen_inetaddr_cb = {
> .notifier_call = netxen_inetaddr_event,
> };
> +#else
> +static void
> +netxen_config_indev_addr(struct net_device *dev, unsigned long event)
> +{ }
> #endif
>
> static struct pci_driver netxen_driver = {
>
>
>
>
> ---
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-09-11 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 22:41 [PATCH -next] netxen: build fix for INET=n Randy Dunlap
2009-09-11 22:46 ` Dhananjay Phadke [this message]
2009-09-11 22:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAAD345.4090902@qlogic.com \
--to=dhananjay.phadke@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox