From: Sebastian Haas <haas-zsNKPWJ8Pib6hrUXjxyGrA@public.gmane.org>
To: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
oliver-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org,
greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org,
wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org
Subject: Re: [PATCH 2/2] ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface
Date: Tue, 15 Sep 2009 13:36:40 +0200 [thread overview]
Message-ID: <4AAF7C48.6080003@ems-wuensche.com> (raw)
In-Reply-To: <4AAF762A.5030605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Eric,
Eric Dumazet schrieb:
> Sebastian Haas a écrit :
>> This patch adds support for one channel CAN/USB interace CPC-USB/ARM7 from
>> EMS Dr. Thomas Wuensche (http://www.ems-wuensche.com).
>>
>> Signed-off-by: Sebastian Haas <haas@ems-wuensche.com>
>> ---
>>
>
> ...
>
>> + netif_rx(skb);
>> +
>> + dev->netdev->last_rx = jiffies;
>
> Please dont update last_rx unless your driver *really* needs to.
>
> drivers/net/sky2.c is an example of driver that has to update ->last_rx
> for its internal use.
Okay, I see. Removed, thanks.
Cheers, Sebastian Haas
--
EMS Dr. Thomas Wuensche e.K.
Sonnenhang 3
85304 Ilmmuenster
HRA Neuburg a.d. Donau, HR-Nr. 70.106
Phone: +49-8441-490260
Fax : +49-8441-81860
http://www.ems-wuensche.com
_______________________________________________
Socketcan-core mailing list
Socketcan-core@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/socketcan-core
next prev parent reply other threads:[~2009-09-15 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090914080945.5441.45509.stgit@localhost.localdomain>
[not found] ` <20090914082229.5441.16650.stgit@localhost.localdomain>
[not found] ` <20090914082229.5441.16650.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-09-15 10:57 ` [PATCH 2/2] ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface Wolfgang Grandegger
2009-09-15 11:40 ` Sebastian Haas
[not found] ` <4AAF7D47.1070005-zsNKPWJ8Pib6hrUXjxyGrA@public.gmane.org>
2009-09-15 12:05 ` Wolfgang Grandegger
[not found] ` <4AAF82F4.6040708-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-09-15 13:33 ` Sebastian Haas
2009-09-15 11:10 ` Eric Dumazet
[not found] ` <4AAF762A.5030605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-09-15 11:36 ` Sebastian Haas [this message]
2009-09-11 10:54 [PATCH 1/2] cpc-usb: Removed driver from staging tree Sebastian Haas
[not found] ` <20090911105449.7815.65368.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-09-11 10:54 ` [PATCH 2/2] ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface Sebastian Haas
[not found] ` <20090911105455.7815.12354.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-09-11 11:36 ` Wolfgang Grandegger
2009-09-11 12:07 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAF7C48.6080003@ems-wuensche.com \
--to=haas-zsnkpwj8pib6hruxjxygra@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oliver-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).