From: Ben Greear <greearb@candelatech.com>
To: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: NetDev <netdev@vger.kernel.org>
Subject: Re: Getting physical packet counts with LRO enabled with ixgbe?
Date: Wed, 23 Sep 2009 14:56:09 -0700 [thread overview]
Message-ID: <4ABA9979.2070808@candelatech.com> (raw)
In-Reply-To: <4ABA9509.7000008@candelatech.com>
I'm poking at the ixgbe_main code in 2.6.31.
It seems from the spec sheet that the 82599 supports the GORCH.
/* 82598 hardware only has a 32 bit counter in the high register */
if (hw->mac.type == ixgbe_mac_82599EB) {
adapter->stats.gorc += IXGBE_READ_REG(hw, IXGBE_GORCL);
IXGBE_READ_REG(hw, IXGBE_GORCH); /* to clear */
stats.gorc is 64-bit, so any reason not to grab the 4 high-bits out of GORCL
and add them to stats.gorc instead of just clearing them as this
code seems to do?
That gives us some precious extra seconds to read counters before they
wrap :)
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2009-09-23 21:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 16:40 Getting physical packet counts with LRO enabled with ixgbe? Ben Greear
2009-09-23 18:32 ` Peter P Waskiewicz Jr
2009-09-23 18:46 ` Ben Greear
2009-09-23 18:50 ` Peter P Waskiewicz Jr
2009-09-23 18:56 ` Ben Greear
2009-09-23 19:03 ` Rick Jones
2009-09-25 21:45 ` Herbert Xu
2009-09-25 21:50 ` Ben Greear
2009-09-25 21:59 ` David Miller
2009-09-25 22:01 ` Herbert Xu
2009-09-25 22:12 ` Ben Greear
2009-09-25 22:40 ` Peter P Waskiewicz Jr
2009-09-25 22:09 ` Herbert Xu
2009-09-25 21:56 ` Peter P Waskiewicz Jr
2009-09-25 22:10 ` Herbert Xu
2009-09-23 21:37 ` Ben Greear
2009-09-23 21:56 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABA9979.2070808@candelatech.com \
--to=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).