From: Rick Jones <rick.jones2@hp.com>
To: Ben Greear <greearb@candelatech.com>
Cc: NetDev <netdev@vger.kernel.org>
Subject: Re: ixgbe patch to provide NIC's tx/rx counters via ethtool
Date: Thu, 24 Sep 2009 09:30:43 -0700 [thread overview]
Message-ID: <4ABB9EB3.1000307@hp.com> (raw)
In-Reply-To: <4ABAD48C.9010808@candelatech.com>
Ben Greear wrote:
> Rick Jones wrote:
>> Ben Greear wrote:
>>
>>> When LRO is enabled, the received packet and byte counters represent the
>>> LRO'd packets, not the packets/bytes on the wire.
>>
>>
>> When LRO is enabled, are all the bytes on the wire actually
>> transferred into the host?
>
> No...the ethernet, IP and TCP headers and such are not, for packets that
> are combined into a single large SKB.
>
> That is why the driver counts them wrong. The bytes are off by a few
> percentage points, but the packet count is off by an order of magnitude.
An overly philosphical question perhaps, but are ethtool stats supposed to
represent what was on the wire, or what entered the host?
rick
next prev parent reply other threads:[~2009-09-24 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 22:36 ixgbe patch to provide NIC's tx/rx counters via ethtool Ben Greear
2009-09-24 0:02 ` Rick Jones
2009-09-24 2:08 ` Ben Greear
2009-09-24 16:30 ` Rick Jones [this message]
2009-09-24 17:07 ` Ben Greear
2009-09-24 18:28 ` Peter P Waskiewicz Jr
2009-09-24 19:10 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABB9EB3.1000307@hp.com \
--to=rick.jones2@hp.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).