From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: fubar@us.ibm.com, netdev@vger.kernel.org, andy@greyhouse.net
Subject: Re: [PATCH 3/3] bonding: send ARP requests on interfaces other than the primary for tlb/alb
Date: Wed, 30 Sep 2009 09:49:37 +0200 [thread overview]
Message-ID: <4AC30D91.9070507@gmail.com> (raw)
In-Reply-To: <20090930.002721.160750704.davem@davemloft.net>
David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 30 Sep 2009 07:20:23 +0200
>
>> Jay Vosburgh a écrit :
>>> - /* The ARP relpy packets must be delayed so that
>>> - * they can cancel out the influence of the ARP request.
>>> - */
>> COmments should have the following form :
>> /*
>> * This is a fine comment
>> */
>
> I definitely prefer what is used in the patch, whereas your suggestion
> wastes a precious line on the screen and doesn't look markedly better
> at all.
>
> Look at any TCP protocol source file and you'll see the consistent
> application of:
>
> /* This form of
> * comment.
> */
>
> there.
No problem David, I dont want to waste time to discuss this kind of stuff,
but you know my own opinion, and I know yours as well !
As a non native, some things that are painful details for you definitly help
my brain to decode English sentences. Uppercase on first letter, final point,
spelling, ...
next prev parent reply other threads:[~2009-09-30 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 0:15 [PATCH net-next-2.6 0/3] bonding: TLB / ALB changes Jay Vosburgh
2009-09-30 0:15 ` [PATCH 1/3] bonding: allow previous slave to be used when re-balancing traffic on tlb/alb interfaces Jay Vosburgh
2009-09-30 0:15 ` [PATCH 2/3] bonding: make sure tx and rx hash tables stay in sync when using alb mode Jay Vosburgh
2009-09-30 0:15 ` [PATCH 3/3] bonding: send ARP requests on interfaces other than the primary for tlb/alb Jay Vosburgh
2009-09-30 5:20 ` Eric Dumazet
2009-09-30 5:40 ` Jarek Poplawski
2009-09-30 5:49 ` Eric Dumazet
2009-09-30 7:27 ` David Miller
2009-09-30 7:49 ` Eric Dumazet [this message]
2009-10-03 1:13 ` [PATCH 1/3] bonding: allow previous slave to be used when re-balancing traffic on tlb/alb interfaces Jay Vosburgh
2009-10-05 10:43 ` David Miller
2009-10-06 16:27 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC30D91.9070507@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).