* [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info
@ 2009-09-30 14:07 Eric Dumazet
2009-09-30 17:26 ` Matt Carlson
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2009-09-30 14:07 UTC (permalink / raw)
To: David S. Miller; +Cc: Matt Carlson, Linux Netdev List, Michael Chan
prev_vlan_tag field is not used.
Patch saves 512*8 bytes per tx queue ring on 64bit arches.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h
index 82b45d8..524691c 100644
--- a/drivers/net/tg3.h
+++ b/drivers/net/tg3.h
@@ -2412,7 +2412,6 @@ struct ring_info {
struct tx_ring_info {
struct sk_buff *skb;
- u32 prev_vlan_tag;
};
struct tg3_config_info {
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info
2009-09-30 14:07 [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info Eric Dumazet
@ 2009-09-30 17:26 ` Matt Carlson
2009-10-01 21:38 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Matt Carlson @ 2009-09-30 17:26 UTC (permalink / raw)
To: Eric Dumazet
Cc: David S. Miller, Matthew Carlson, Linux Netdev List, Michael Chan
On Wed, Sep 30, 2009 at 07:07:52AM -0700, Eric Dumazet wrote:
> prev_vlan_tag field is not used.
>
> Patch saves 512*8 bytes per tx queue ring on 64bit arches.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Looks good to me.
Acked-by: Matthew Carlson <mcarlson@broadcom.com>
> ---
>
> diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h
> index 82b45d8..524691c 100644
> --- a/drivers/net/tg3.h
> +++ b/drivers/net/tg3.h
> @@ -2412,7 +2412,6 @@ struct ring_info {
>
> struct tx_ring_info {
> struct sk_buff *skb;
> - u32 prev_vlan_tag;
> };
>
> struct tg3_config_info {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info
2009-09-30 17:26 ` Matt Carlson
@ 2009-10-01 21:38 ` David Miller
2009-10-02 4:16 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2009-10-01 21:38 UTC (permalink / raw)
To: mcarlson; +Cc: eric.dumazet, netdev, mchan
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Wed, 30 Sep 2009 10:26:43 -0700
> On Wed, Sep 30, 2009 at 07:07:52AM -0700, Eric Dumazet wrote:
>> prev_vlan_tag field is not used.
>>
>> Patch saves 512*8 bytes per tx queue ring on 64bit arches.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Looks good to me.
>
> Acked-by: Matthew Carlson <mcarlson@broadcom.com>
Applied, thanks.
Eric, I had to apply this by hand because:
>> @@ -2412,7 +2412,6 @@ struct ring_info {
>>
>> struct tx_ring_info {
>> struct sk_buff *skb;
>> - u32 prev_vlan_tag;
>> };
Your email client changed tabs into spaces.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info
2009-10-01 21:38 ` David Miller
@ 2009-10-02 4:16 ` Eric Dumazet
0 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2009-10-02 4:16 UTC (permalink / raw)
To: David Miller; +Cc: mcarlson, netdev, mchan
David Miller a écrit :
>
> Applied, thanks.
>
> Eric, I had to apply this by hand because:
>
>>> @@ -2412,7 +2412,6 @@ struct ring_info {
>>>
>>> struct tx_ring_info {
>>> struct sk_buff *skb;
>>> - u32 prev_vlan_tag;
>>> };
>
> Your email client changed tabs into spaces.
Oops, I'm sorry Dave, I did a copy/paste and forgot about tabs.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-02 4:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-30 14:07 [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info Eric Dumazet
2009-09-30 17:26 ` Matt Carlson
2009-10-01 21:38 ` David Miller
2009-10-02 4:16 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).