From: William Allen Simpson <william.allen.simpson@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH] TCPCT-1: adding a sysctl
Date: Fri, 02 Oct 2009 20:32:09 -0400 [thread overview]
Message-ID: <4AC69B89.5010604@gmail.com> (raw)
In-Reply-To: <20091002.154808.137771153.davem@davemloft.net>
David Miller wrote:
> From: William Allen Simpson <william.allen.simpson@gmail.com>
>> Ummm, I was following the suggested practice of breaking it into
>> smaller
>> pieces for review. This is just the control functions and headers.
>> I've
>> actually completed most of the port, and am champing at the bit.
>
> We can't review the helper functions and infrastructure properly until
> we can see how they are actually used.
>
> Seeing how they are used shows us how well they are designed.
>
> Otherwise asking for a is absolutely pointless as we have no context
> in which to judge the code you're showing us.
>
Thanks. I'd hand-split my code into much smaller patches for review.
Now, I know there are patches that are *too* small....
I've merged the several things you've mentioned, and will post it soon
(after making sure it compiles and runs separately).
next prev parent reply other threads:[~2009-10-03 0:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 4:00 query: adding a sysctl William Allen Simpson
2009-10-02 5:57 ` Stephen Hemminger
2009-10-02 14:58 ` [PATCH] TCPCT-1: " William Allen Simpson
2009-10-02 17:52 ` William Allen Simpson
2009-10-02 22:00 ` William Allen Simpson
2009-10-02 21:06 ` Andi Kleen
2009-10-02 21:46 ` William Allen Simpson
2009-10-02 22:48 ` David Miller
2009-10-03 0:32 ` William Allen Simpson [this message]
2009-10-03 6:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC69B89.5010604@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).