netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: William Allen Simpson <william.allen.simpson@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH] TCPCT+1: initial SYN exchange with SYNACK data
Date: Mon, 05 Oct 2009 03:45:51 -0400	[thread overview]
Message-ID: <4AC9A42F.7010302@gmail.com> (raw)
In-Reply-To: <4AC79905.1030904@gmail.com>

As I'm new to Linux kernel development, this was based entirely on code
previously reviewed (by Miller), as that seemed a good path for me to learn
proper coding and style.

Now that I'm trying to grok Linux locking functions for the next patch, I've
noticed that setsockopt code uses lock_sock(), but getsockopt doesn't.  In a
preemptive kernel, or with SMP, isn't there a possibility that these socket
values could be modified or destroyed at the same time?

I'm especially concerned here, as there are kref blocks, and they could be
left pointing into the weeds?

      parent reply	other threads:[~2009-10-05  7:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-03 18:33 [PATCH] TCPCT+1: initial SYN exchange with SYNACK data William Allen Simpson
2009-10-05  7:27 ` David Miller
2009-10-05  7:58   ` William Allen Simpson
2009-10-05  8:06     ` David Miller
2009-10-05  8:23       ` William Allen Simpson
2009-10-05  8:50         ` David Miller
2009-10-05  9:22         ` Eric Dumazet
2009-10-05  8:11     ` William Allen Simpson
2009-10-05  8:45       ` David Miller
2009-10-05 17:42         ` William Allen Simpson
2009-10-05  7:45 ` William Allen Simpson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC9A42F.7010302@gmail.com \
    --to=william.allen.simpson@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).